From: Or Gerlitz <ogerlitz@mellanox•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: Or Gerlitz <or.gerlitz@gmail•com>, netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next V2 1/3] net: Add GRO support for UDP encapsulating protocols
Date: Wed, 8 Jan 2014 14:15:13 +0200 [thread overview]
Message-ID: <52CD4151.9050100@mellanox.com> (raw)
In-Reply-To: <1389182291.26646.79.camel@edumazet-glaptop2.roam.corp.google.com>
On 08/01/2014 13:58, Eric Dumazet wrote:
> On Wed, 2014-01-08 at 10:04 +0200, Or Gerlitz wrote:
>> On 07/01/2014 23:38, Eric Dumazet wrote:
>>> On Tue, 2014-01-07 at 22:37 +0200, Or Gerlitz wrote:
>>>
>>>> So here's the thing, per my understanding we want to GRO only received
>>>> **encapsulated** packets whose checksum status is != CHECKSUM_NONE
>>>> which means the NIC has some support for doing RX checksum of
>>>> encapsulated packets. Per the current convension, in that case the NIC
>>>> RX code has to set skb->encapsulation see 6a674e9c75b17 "net: Add
>>>> support for hardware-offloaded encapsulation" this convension is
>>>> implemented in the current drivers that have HW offloads for
>>>> encapsulated packets (bnx2x, i40e and mlx4)
>>> I do not think its true.
>>>
>>> Some drivers set CHECKSUM_COMPLETE even for regular UDP frames...
>>>
>>> git grep -n CHECKSUM_COMPLETE -- drivers/net
>>>
>>>
>>>
>> Eric, the point I was trying to make is that as long as the driver set a
>> value which is different from CHECKSUM_NONE
>> for an skb who carry encapsulated packet, we want skb->encapsulation to
>> be set, per the architecture dictated by the above commit.
> Then this point is obviously wrong. Your interpretation is wrong, I am very sorry.
> skb->encapsulation _might_ be set, only if the NIC is performing header
> analysis. CHECKSUM_COMPLETE support doesn't require header analysis.
>
>
>
>
fair enough && thanks for shedding more light on this - so in that
respect, the gro handler for udp encapsulated packets will not flush skb
who is either marked with CHECKSUM_COMPLETE or has skb->encapsulation set.
Or.
next prev parent reply other threads:[~2014-01-08 12:15 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 15:29 [PATCH net-next V2 0/3] net: Add GRO support for UDP encapsulating protocols Or Gerlitz
2014-01-07 15:29 ` [PATCH net-next V2 1/3] " Or Gerlitz
2014-01-07 16:33 ` Eric Dumazet
2014-01-07 20:19 ` Or Gerlitz
2014-01-07 20:32 ` Eric Dumazet
2014-01-07 20:37 ` Or Gerlitz
2014-01-07 21:38 ` Eric Dumazet
2014-01-08 8:04 ` Or Gerlitz
[not found] ` <1389182291.26646.79.camel@edumazet-glaptop2.roam.corp.google.com>
2014-01-08 12:15 ` Or Gerlitz [this message]
2014-01-07 22:11 ` Jerry Chu
2014-01-08 8:02 ` Or Gerlitz
2014-01-09 3:12 ` Jerry Chu
2014-01-09 6:35 ` Or Gerlitz
2014-01-09 7:19 ` Or Gerlitz
2014-01-07 18:44 ` Tom Herbert
2014-01-07 20:21 ` Or Gerlitz
2014-01-07 23:04 ` Tom Herbert
2014-01-08 16:11 ` Or Gerlitz
2014-01-08 16:29 ` Tom Herbert
2014-01-08 16:31 ` Or Gerlitz
2014-01-07 21:19 ` David Miller
2014-01-07 21:40 ` Tom Herbert
2014-01-07 15:29 ` [PATCH net-next V2 2/3] net: Export gro_find_by_type helpers Or Gerlitz
2014-01-07 15:29 ` [PATCH net-next V2 3/3] net: Add GRO support for vxlan traffic Or Gerlitz
2014-01-07 16:34 ` Eric Dumazet
2014-01-07 19:43 ` Or Gerlitz
2014-01-07 20:04 ` Eric Dumazet
2014-01-07 20:10 ` Or Gerlitz
2014-01-07 18:08 ` Tom Herbert
2014-01-07 19:43 ` Or Gerlitz
2014-01-07 20:02 ` Eric Dumazet
2014-01-07 20:12 ` Or Gerlitz
2014-01-07 21:09 ` Tom Herbert
2014-01-08 9:45 ` Or Gerlitz
[not found] ` <CAJZOPZLsMvmHwmMjhsuKb__2HncMXMm=p6UFnT4XX5d8hZnGxw@mail.gmail.com>
2014-01-07 19:52 ` Tom Herbert
2014-01-07 16:45 ` [PATCH net-next V2 0/3] net: Add GRO support for UDP encapsulating protocols Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CD4151.9050100@mellanox.com \
--to=ogerlitz@mellanox$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=or.gerlitz@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox