Subject: Re: [PATCH net-next] net: vxlan: when lower dev unregisters remove vxlan dev as well

From: Daniel Borkmann <[email-masked]>
Date: Fri, 10 Jan 2014 20:16:48 +0100

On 01/10/2014 08:12 PM, Stephen Hemminger wrote:
> On Fri, 10 Jan 2014 20:07:12 +0100
> Daniel Borkmann <[email-masked]> wrote:
>
>>>> +       BUG_ON(!rtnl_is_locked());
>>>
>>>
>>> This is not necessary at all, it is known that netdev notication
>>> holds rtnl lock.
>>
>> We're not in fast-path, and if someone would call that function outside
>> of the notifier chain, it might be good to check if the lock was taken,
>> but if there's a strong opinion to not have that, I'll just remove it
>
> First, the standard way to do this is ASSERT_RTNL()
>
> Second, it is unnecessary. The function is local, only called through
> notifier and notifiers always have RTNL held.

Ok, I'll just remove it, and resend if you're fine with this.