Subject: Re: [Patch net-next 4/7] net_sched: optimize tcf_match_indev()

From: Jamal Hadi Salim <[email-masked]>
Date: Sun, 12 Jan 2014 07:50:01 -0500

On 01/09/14 19:14, Cong Wang wrote:
> tcf_match_indev() is called in fast path, it is not wise to
> search for a netdev by ifindex and then compare by its name,
> just compare the ifindex.
>
> Also, dev->name could be changed by user-space, therefore
> the match would be always fail, but dev->ifindex could
> be consistent.
>
> BTW, this will also save some bytes from the core struct of u32.
>

excellent.

Signed-off-by: Jamal Hadi Salim <[email-masked]>

cheers,
jamal