From: Ding Tianhong <dingtianhong@huawei•com>
To: Veaceslav Falico <vfalico@redhat•com>
Cc: Jay Vosburgh <fubar@us•ibm.com>, Netdev <netdev@vger•kernel.org>,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH net] bonding: reset the slave's mtu when its be changed
Date: Tue, 14 Jan 2014 10:11:45 +0800 [thread overview]
Message-ID: <52D49CE1.6040900@huawei.com> (raw)
In-Reply-To: <52D225A2.3070208@huawei.com>
On 2014/1/12 13:18, Ding Tianhong wrote:
> On 2014/1/10 20:19, Veaceslav Falico wrote:
>> On Fri, Jan 10, 2014 at 07:32:51PM +0800, Ding Tianhong wrote:
>>> All slave should have the same mtu with mastet's, and the bond do it when
>>> enslave the slave, but the user could change the slave's mtu, it will cause
>>> the master and slave have different mtu, althrough in AB mode, it does not
>>> matter if the slave is not the current slave, but in other mode, it is incorrect,
>>> so reset the slave's mtu like the master set.
>>
>> Why "net"? It's not a bugfix, it's a feature, and really discussable.
>>
>> Also, wrt the actual change - why do you think it's incorrect for slaves in
>> bonding mode other than AB to have different MTU values? I don't see any
>> reason for it, from the top of the head.
>>
>
> Ok, I will test more situation for every mode when slave's mtu changed, I am not sure
> what will happened yet, if some links was interrupt, I thinks it is a bug.
>
>>>
I have test several mode for bonding when the slave mtu changed:
RR(0) 0<mtu<1500 ok
AB(1) 0<mtu<1500 loss packets
XOR(2) 0<mtu<1500 ok
Broadcast(3) 0<mtu<1500 ok
LACP 0<mtu<1500 loss packets
so I think we should not let the mtu set for slave.
next prev parent reply other threads:[~2014-01-14 2:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 11:32 [PATCH net] bonding: reset the slave's mtu when its be changed Ding Tianhong
2014-01-10 12:19 ` Veaceslav Falico
2014-01-12 5:18 ` Ding Tianhong
2014-01-14 2:11 ` Ding Tianhong [this message]
2014-01-14 6:03 ` Veaceslav Falico
2014-01-10 18:33 ` David Miller
2014-01-10 19:41 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D49CE1.6040900@huawei.com \
--to=dingtianhong@huawei$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=fubar@us$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vfalico@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox