Subject: Re: [net-next 5/6] i40e: trivial cleanup

From: Sergei Shtylyov <[email-masked]>
Date: Tue, 14 Jan 2014 18:22:14 +0400

Hello.

On 14-01-2014 12:49, Aaron Brown wrote:

> From: Jesse Brandeburg <[email-masked]>

> Remove some un-necessary parenthesis.

> Signed-off-by: Jesse Brandeburg <[email-masked]>
> Tested-by: Kavindya Deegala <[email-masked]>
> Signed-off-by: Aaron Brown <[email-masked]>
> ---
>   drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)

> diff --git a/drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c b/drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c
> index 101ed41..d5d98fe 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c
> @@ -485,8 +485,7 @@ i40e_status i40e_configure_lan_hmc(struct i40e_hw *hw,
>   		/* Make one big object, a single SD */
>   		info.count = 1;
>   		ret_code = i40e_create_lan_hmc_object(hw, &info);
> -		if ((ret_code) &&
> -		    (model == I40E_HMC_MODEL_DIRECT_PREFERRED))
> +		if (ret_code && (model == I40E_HMC_MODEL_DIRECT_PREFERRED))

    Parens around == are also unnecessary, if you're at it.

WBR, Sergei