From: Or Gerlitz <ogerlitz@mellanox•com>
To: David Miller <davem@davemloft•net>
Cc: netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next V3 0/3] net: Add GRO support for UDP encapsulating protocols
Date: Tue, 14 Jan 2014 18:06:55 +0200 [thread overview]
Message-ID: <52D5609F.8010301@mellanox.com> (raw)
In-Reply-To: <1389715212-14504-1-git-send-email-ogerlitz@mellanox.com>
On 14/01/2014 18:00, Or Gerlitz wrote:
> This series adds GRO handlers for protocols that do UDP encapsulation, with the
> intent of being able to coalesce packets which encapsulate packets belonging to
> the same TCP session.
>
> For GRO purposes, the destination UDP port takes the role of the ether type
> field in the ethernet header or the next protocol in the IP header.
>
> The UDP GRO handler will only attempt to coalesce packets whose destination
> port is registered to have gro handler.
>
> The patches done against net-next ae237b3ede64 "net: 3com: fix
> warning for incorrect type in argument"
>
> Or.
>
>
> v3 --> v4 changes:
>
> - applied feedback from Tom on some micro-optimizations that save
> branches and goto directives in the udp gro logic
>
> - applied feedback from Eric on correct RCU programming for the
> add/remove flow of the upper protocols udp gro handlers
>
>
> v2 --> v3 changes:
>
> - moved to use linked list to store the udp gro handlers, this solves the
> problem of consuming 512KB of memory for the handlers.
>
> - use a mark on the skb GRO CB data to disallow running the udp gro_receive twice
> on a packet, this solves the problem of udp encapsulated packets whose inner VM
> packet is udp and happen to carry a port which has registered offloads - and flush it.
>
> - invoke the udp offload protocol registration and de-registration from the vxlan driver
> in a sleepable context
>
> For unclear some reason I got this warning when the vxlan driver deletes the
> udp offload structure
> *** BLURB HERE ***
Sorry for the spam, the above three lines are leftovers from the V3
cover letter, same for the subject line of this
cover-letter which carries "V3" this *is* V4, will make sure to avoid
such flushes (....) in the future.
Or.
>
> Or Gerlitz (3):
> net: Add GRO support for UDP encapsulating protocols
> net: Export gro_find_by_type helpers
> net: Add GRO support for vxlan traffic
>
> drivers/net/vxlan.c | 117 +++++++++++++++++++++++++++++++--
> include/linux/netdevice.h | 10 +++-
> include/net/protocol.h | 3 +
> include/net/vxlan.h | 1 +
> net/core/dev.c | 3 +
> net/ipv4/udp_offload.c | 157 +++++++++++++++++++++++++++++++++++++++++++++
> 6 files changed, 283 insertions(+), 8 deletions(-)
>
next prev parent reply other threads:[~2014-01-14 16:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 16:00 [PATCH net-next V3 0/3] net: Add GRO support for UDP encapsulating protocols Or Gerlitz
2014-01-14 16:00 ` [PATCH net-next V4 1/3] " Or Gerlitz
2014-01-14 17:51 ` Tom Herbert
2014-01-14 21:51 ` Or Gerlitz
2014-01-15 0:50 ` Eric Dumazet
2014-01-14 16:00 ` [PATCH net-next V4 2/3] net: Export gro_find_by_type helpers Or Gerlitz
2014-01-14 16:00 ` [PATCH net-next V4 3/3] net: Add GRO support for vxlan traffic Or Gerlitz
2014-01-14 17:59 ` Tom Herbert
2014-01-14 21:47 ` Or Gerlitz
2014-01-20 11:40 ` Or Gerlitz
2014-01-14 16:06 ` Or Gerlitz [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-01-08 20:34 [PATCH net-next V3 0/3] net: Add GRO support for UDP encapsulating protocols Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D5609F.8010301@mellanox.com \
--to=ogerlitz@mellanox$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox