From: Jonathan Cameron <jic23@kernel•org>
To: Richard Weinberger <richard@nod•at>,
kishon@ti•com, anton@enomsg•org, dwmw2@infradead•org,
richardcochran@gmail•com, lidza.louina@gmail•com,
gregkh@linuxfoundation•org, davem@davemloft•net
Cc: marex@denx•de, lars@metafoo•de, linux-iio@vger•kernel.org,
netdev@vger•kernel.org, driverdev-devel@linuxdriverproject•org,
linux-kernel@vger•kernel.org, acourbot@nvidia•com,
devel@driverdev•osuosl.org, florian@openwrt•org,
sebastian.hesselbarth@gmail•com
Subject: Re: [PATCH 7/7] staging,lpc32xx_adc: Add dependency on HAS_IOMEM
Date: Sat, 18 Jan 2014 11:50:16 +0000 [thread overview]
Message-ID: <52DA6A78.9040609@kernel.org> (raw)
In-Reply-To: <1389714345-20165-7-git-send-email-richard@nod.at>
On 14/01/14 15:45, Richard Weinberger wrote:
> On archs like S390 or um this driver cannot build nor work.
> Make it depend on HAS_IOMEM to bypass build failures.
>
> drivers/built-in.o: In function `lpc32xx_adc_probe':
> drivers/staging/iio/adc/lpc32xx_adc.c:149: undefined reference to `devm_ioremap'
>
> Signed-off-by: Richard Weinberger <richard@nod•at>
applied to the fixes-togreg branch of iio.git
Thanks,
> ---
> drivers/staging/iio/adc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/iio/adc/Kconfig b/drivers/staging/iio/adc/Kconfig
> index 7d5d675..3633298 100644
> --- a/drivers/staging/iio/adc/Kconfig
> +++ b/drivers/staging/iio/adc/Kconfig
> @@ -103,6 +103,7 @@ config AD7280
> config LPC32XX_ADC
> tristate "NXP LPC32XX ADC"
> depends on ARCH_LPC32XX || COMPILE_TEST
> + depends on HAS_IOMEM
> help
> Say yes here to build support for the integrated ADC inside the
> LPC32XX SoC. Note that this feature uses the same hardware as the
>
next prev parent reply other threads:[~2014-01-18 11:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 15:45 [PATCH 1/7] ptp_pch: Add dependency on HAS_IOMEM Richard Weinberger
2014-01-14 15:45 ` [PATCH 2/7] staging,dgap: " Richard Weinberger
2014-01-14 15:45 ` [PATCH 3/7] staging,spear_adc: " Richard Weinberger
[not found] ` <1389714345-20165-3-git-send-email-richard-/L3Ra7n9ekc@public.gmane.org>
2014-01-18 11:41 ` Jonathan Cameron
2014-01-14 15:45 ` [PATCH 4/7] phy,exynos: " Richard Weinberger
2014-01-14 15:45 ` [PATCH 5/7] net,marvell: " Richard Weinberger
2014-01-14 15:45 ` [PATCH 6/7] power,goldfish: " Richard Weinberger
2014-01-14 15:45 ` [PATCH 7/7] staging,lpc32xx_adc: " Richard Weinberger
2014-01-18 11:50 ` Jonathan Cameron [this message]
2014-01-15 22:51 ` [PATCH 1/7] ptp_pch: " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DA6A78.9040609@kernel.org \
--to=jic23@kernel$(echo .)org \
--cc=acourbot@nvidia$(echo .)com \
--cc=anton@enomsg$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=driverdev-devel@linuxdriverproject$(echo .)org \
--cc=dwmw2@infradead$(echo .)org \
--cc=florian@openwrt$(echo .)org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=kishon@ti$(echo .)com \
--cc=lars@metafoo$(echo .)de \
--cc=lidza.louina@gmail$(echo .)com \
--cc=linux-iio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=marex@denx$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=richard@nod$(echo .)at \
--cc=richardcochran@gmail$(echo .)com \
--cc=sebastian.hesselbarth@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox