Subject: Re: [Patch net-next 1/6] net_sched: act: fetch hinfo from a->ops->hinfo

From: Jamal Hadi Salim <[email-masked]>
Date: Mon, 20 Jan 2014 07:16:37 -0500

On 01/17/14 14:37, Cong Wang wrote:
> Every action ops has a pointer to hash info, so we don't need to
> hard-code it in each module.
>
> Cc: Jamal Hadi Salim <[email-masked]>
> Cc: David S. Miller <[email-masked]>
> Signed-off-by: Cong Wang <[email-masked]>

Signed-off-by: Jamal Hadi Salim <[email-masked]>

Although changes like the one below (which are in a few places)
are necessary i.e it was more readable before.

> diff --git a/net/sched/act_csum.c b/net/sched/act_csum.c
> index ee28e1c..a9a3185 100644
> --- a/net/sched/act_csum.c
> +++ b/net/sched/act_csum.c

> -		tcf_hash_release(pc, bind, &csum_hash_info);
> +		tcf_hash_release(pc, bind, a->ops->hinfo);
>   		if (!ovr)

cheers,
jamal