Subject: Re: [PATCH] net: Correctly sync addresses from multiple sources to single device

From: Vlad Yasevich <[email-masked]>
Date: Wed, 22 Jan 2014 10:30:45 -0500

On 01/21/2014 05:53 PM, David Miller wrote:
> From: Vlad Yasevich <[email-masked]>
> Date: Fri, 17 Jan 2014 14:52:12 -0500
> 
>> When we have multiple devices attempting to sync the same address
>> to a single destination, each device should be permitted to sync
>> it once.  To accomplish this, pass the sync count of the source
>> address to __hw_addr_add_ex().  'sync_cnt' tracks how many time
>> a given address has been successfully synced.  If the address
>> is found in the destination list, but the 'sync_cnt' of the source
>> is 0, then this address has not been synced from this interface
>> and we need to allow the sync operation to succeed thus incrementing
>> reference counts.
>>
>> Reported-by: Andrey Dmitrov <[email-masked]>
>> CC: Andrey Dmitrov <[email-masked]>
>> Signed-off-by: Vlad Yasevich <[email-masked]>
> 
> I applied this to net-next since 3.13 just got released, and it doesn't
> compile.
> 
> net/core/dev_addr_lists.c: In function ‘__hw_addr_sync_one’:
> net/core/dev_addr_lists.c:144:26: error: ‘struct netdev_hw_addr’ has no member named ‘sync_count’
> 

That does it...  Time to add a hook to format_patch to check for dirty
index.

-vlad