From: Tony Prisk <linux-ci5G2KO2hbZ+pU9mqzGVBQ@public•gmane.org>
To: Alexey Charkov <alchark-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>,
Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>
Cc: netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
Roger Luethi <rl-7uj+XXdSDtwfv37vnLkPlQ@public•gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>
Subject: Re: [PATCH 3/3] net: via-rhine: add OF bus binding
Date: Wed, 29 Jan 2014 16:44:41 +1300 [thread overview]
Message-ID: <52E87929.30708@prisktech.co.nz> (raw)
In-Reply-To: <CABjd4Yxo0Pp+QtTuXhKBT9KdVhUk12x2L8+FBL_ZWmPYopG2JQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 29/01/14 07:27, Alexey Charkov wrote:
> 2014/1/27 Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>:
>> On Mon, Jan 27, 2014 at 5:51 AM, Alexey Charkov <alchark-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org> wrote:
>>> This should make the driver usable with VIA/WonderMedia ARM-based
>>> Systems-on-Chip integrated Rhine III adapters. Note that these
>>> are always in MMIO mode, and don't have any known EEPROM.
>>>
>>> Signed-off-by: Alexey Charkov <alchark-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>
>>> Signed-off-by: Roger Luethi <rl-7uj+XXdSDtwfv37vnLkPlQ@public•gmane.org>
>>> ---
>>> .../devicetree/bindings/net/via-rhine.txt | 18 ++
>>> drivers/net/ethernet/via/Kconfig | 2 +-
>>> drivers/net/ethernet/via/via-rhine.c | 293 +++++++++++++--------
>>> 3 files changed, 200 insertions(+), 113 deletions(-)
>>> create mode 100644 Documentation/devicetree/bindings/net/via-rhine.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/via-rhine.txt b/Documentation/devicetree/bindings/net/via-rhine.txt
>>> new file mode 100644
>>> index 0000000..684dd3a
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/net/via-rhine.txt
>>> @@ -0,0 +1,18 @@
>>> +* VIA Rhine 10/100 Network Controller
>>> +
>>> +Required properties:
>>> +- compatible : Should be "via,rhine"
>> This should be more specific rather than...
>>
>>> +- reg : Address and length of the io space
>>> +- interrupts : Should contain the controller interrupt line
>>> +- rhine,revision : Rhine core revision, used to inform the
>>> + driver of quirks and capabilities to expect from
>>> + the device. Mimics the respective PCI attribute.
>> having this property. The OF match table can then have the quirks set
>> based on compatible strings.
> Sounds fair. Do you think something like the following would fly?
>
> Required properties:
> - compatible : Should be "via,rhine-soc-vt8500" for integrated Rhine
> cores found in SoC's such as VIA VT8500, WonderMedia WM8950 and
> possibly others. These are listed as 1106:3106 rev. 0x84 on the
> virtual PCI bus under vendor-provided kernels.
Does it need a special name? I would have assumed they are using their
own IP for the VT6105 or VT6106S.
Then you can use it to add quirks later on if needed.
Regards
Tony Prisk
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-01-29 3:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1385227995-3956-1-git-send-email-alchark@gmail.com>
2013-11-30 19:07 ` [PATCH 0/3] net: via-rhine: add support for on-chip Rhine controllers Alexey Charkov
[not found] ` <1385227995-3956-1-git-send-email-alchark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-01-27 11:51 ` [PATCH 0/3] Resubmit: " Alexey Charkov
2014-01-27 11:51 ` [PATCH 1/3] net: via-rhine: switch to generic DMA functions Alexey Charkov
2014-01-27 14:49 ` Ben Hutchings
[not found] ` <1390834190.2735.143.camel-nDn/Rdv9kqW9Jme8/bJn5UCKIB8iOfG2tUK59QYPAWc@public.gmane.org>
2014-01-27 15:26 ` Alexey Charkov
[not found] ` <CABjd4Yyq_Mia=2DkC83Wpi6o1o3m5+yoMcDL4WdZmuLvRtu6qg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-01-27 15:28 ` Ben Hutchings
2014-01-27 11:51 ` [PATCH 2/3] net: via-rhine: reduce usage of the PCI-specific struct Alexey Charkov
2014-01-27 11:51 ` [PATCH 3/3] net: via-rhine: add OF bus binding Alexey Charkov
[not found] ` <1390823503-24087-4-git-send-email-alchark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-01-27 14:57 ` Ben Hutchings
[not found] ` <1390834654.2735.148.camel-nDn/Rdv9kqW9Jme8/bJn5UCKIB8iOfG2tUK59QYPAWc@public.gmane.org>
2014-01-27 15:34 ` Alexey Charkov
2014-01-27 23:40 ` Ben Hutchings
2014-01-28 18:31 ` Alexey Charkov
[not found] ` <CABjd4Yx5HtbGjo_ZsOJ5SvqFQZey1fv5K36PD=D9fUUn0SanVQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-01-31 14:24 ` Ben Hutchings
2014-01-27 15:56 ` Rob Herring
2014-01-28 18:27 ` Alexey Charkov
[not found] ` <CABjd4Yxo0Pp+QtTuXhKBT9KdVhUk12x2L8+FBL_ZWmPYopG2JQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-01-29 3:44 ` Tony Prisk [this message]
[not found] ` <52E87929.30708-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>
2014-01-29 5:20 ` Alexey Charkov
[not found] ` <CABjd4Yy2pFr=qr1_e3XqupHngp_mF0GcDT0hCM46v=tNNDY1hw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-01-29 14:59 ` Rob Herring
2014-01-29 13:46 ` Rob Herring
[not found] ` <1390823503-24087-1-git-send-email-alchark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-04-22 15:28 ` [PATCH v2 0/3] net: via-rhine: add support for on-chip Rhine controllers Alexey Charkov
2014-04-22 15:28 ` [PATCH 1/3] net: via-rhine: switch to generic DMA functions Alexey Charkov
2014-04-22 15:28 ` [PATCH 2/3] net: via-rhine: reduce usage of the PCI-specific struct Alexey Charkov
2014-04-22 15:28 ` [PATCH 3/3] net: via-rhine: add OF bus binding Alexey Charkov
[not found] ` <1398180489-20230-4-git-send-email-alchark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-04-22 15:46 ` Rob Herring
[not found] ` <1398180489-20230-1-git-send-email-alchark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-04-23 19:26 ` [PATCH v2 0/3] net: via-rhine: add support for on-chip Rhine controllers David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E87929.30708@prisktech.co.nz \
--to=linux-ci5g2ko2hbz+pu9mqzgvbq@public$(echo .)gmane.org \
--cc=alchark-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=rl-7uj+XXdSDtwfv37vnLkPlQ@public$(echo .)gmane.org \
--cc=robherring2-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox