Subject: Re: [RFC PATCH] net: core: move core networking work to power efficient workqueue

From: Antonio Quartulli <[email-masked]>
Date: Fri, 31 Jan 2014 01:48:37 +0100

On 31/01/14 01:33, Zoran Markovic wrote:
> From: Shaibal Dutta <[email-masked]>

[...]

> -		schedule_delayed_work(&linkwatch_work, delay);
> +		queue_delayed_work(system_power_efficient_wq,
> +			&linkwatch_work, delay);

before talking about technical details, here and in other spots of this
patch the alignment is wrong. I think checkpatch should have said
something about it. The first parameter on the new line should be
aligned up to the column after the opening parenthesis.

Regards,

>  }
>  
>  
> diff --git a/net/core/netpoll.c b/net/core/netpoll.c
> index c03f3de..2c8f839 100644
> --- a/net/core/netpoll.c
> +++ b/net/core/netpoll.c
> @@ -101,7 +101,8 @@ static void queue_process(struct work_struct *work)
>  			__netif_tx_unlock(txq);
>  			local_irq_restore(flags);
>  
> -			schedule_delayed_work(&npinfo->tx_work, HZ/10);
> +			queue_delayed_work(system_power_efficient_wq,
> +				&npinfo->tx_work, HZ/10);
>  			return;
>  		}
>  		__netif_tx_unlock(txq);
> @@ -423,7 +424,8 @@ void netpoll_send_skb_on_dev(struct netpoll *np, struct sk_buff *skb,
>  
>  	if (status != NETDEV_TX_OK) {
>  		skb_queue_tail(&npinfo->txq, skb);
> -		schedule_delayed_work(&npinfo->tx_work,0);
> +		queue_delayed_work(system_power_efficient_wq,
> +			&npinfo->tx_work, 0);
>  	}
>  }
>  EXPORT_SYMBOL(netpoll_send_skb_on_dev);
> 

-- 
Antonio Quartulli