From: Larry Finger <Larry.Finger@lwfinger•net>
To: Greg KH <gregkh@linuxfoundation•org>
Cc: devel@driverdev•osuosl.org, netdev@vger•kernel.org
Subject: Re: [PATCH] staging: r8188eu: Fix typo in USB_DEVICE list
Date: Sun, 02 Feb 2014 22:16:04 -0600 [thread overview]
Message-ID: <52EF1804.50804@lwfinger.net> (raw)
In-Reply-To: <20140202212650.GA27215@kroah.com>
On 02/02/2014 03:26 PM, Greg KH wrote:
> On Sun, Feb 02, 2014 at 02:07:06PM -0600, Larry Finger wrote:
>> There is a typo in the device list that interchanges the vendor and
>> product codes for one of the entries.
>>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger•net>
>> ---
>> drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
>> index 0a341d6..e9e3c76 100644
>> --- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
>> +++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
>> @@ -53,7 +53,7 @@ static struct usb_device_id rtw_usb_id_tbl[] = {
>> {USB_DEVICE(USB_VENDER_ID_REALTEK, 0x0179)}, /* 8188ETV */
>> /*=== Customer ID ===*/
>> /****** 8188EUS ********/
>> - {USB_DEVICE(0x8179, 0x07B8)}, /* Abocom - Abocom */
>> + {USB_DEVICE(0x07bb, 0x8179)}, /* Abocom - Abocom */
>
> Becides the b8 -> bb issue, are you sure this is correct? I've seen
> lots of USB devices that got this backwards (vendor id in the product id
> place), so it wouldn't be the first time it's happened.
The listing at http://www.linux-usb.org/usb.ids shows that the vendor code for
AboCom Systems Inc is 0x07b8. Although it does not show a device id of 0x8179,
I'm pretty sure that this listing has reversed the two entries.
Larry
next prev parent reply other threads:[~2014-02-03 4:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-02 20:07 [PATCH] staging: r8188eu: Fix typo in USB_DEVICE list Larry Finger
2014-02-02 21:04 ` Randy Dunlap
2014-02-02 21:22 ` Larry Finger
2014-02-02 21:26 ` Greg KH
2014-02-03 4:16 ` Larry Finger [this message]
2014-02-03 9:17 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52EF1804.50804@lwfinger.net \
--to=larry.finger@lwfinger$(echo .)net \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox