From: Amir Vadai <amirv@mellanox•com>
To: Venkata Duvvuru <VenkatKumar.Duvvuru@Emulex•Com>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
Ben Hutchings <bhutchings@solarflare•com>
Subject: Re: Patchset - Support for configurable RSS hash key
Date: Wed, 5 Feb 2014 14:24:43 +0200 [thread overview]
Message-ID: <52F22D8B.4000408@mellanox.com> (raw)
In-Reply-To: <BF3270C86E8B1349A26C34E4EC1C44CB2C86E05F@CMEXMB1.ad.emulex.com>
On 05/02/2014 14:20, Venkata Duvvuru wrote:
>
>
>> -----Original Message-----
>> From: Amir Vadai [mailto:amirv.mellanox@gmail•com] On Behalf Of Amir
>> Vadai
>> Sent: Sunday, February 02, 2014 9:40 PM
>> To: Venkata Duvvuru
>> Cc: netdev@vger•kernel.org; Ben Hutchings
>> Subject: Re: Patchset - Support for configurable RSS hash key
>>
>> On 17/01/14 13:02 +0000, Venkata Duvvuru wrote:
>>> NIC drivers that support RSS use either a hard-coded value or a random
>> value for the RSS hash key. Irrespective of the type of the key used, the user
>> would want to change the hash key if he/she is not satisfied with the
>> effectiveness of the default hash-key in spreading the incoming flows evenly
>> across the RSS queues.
>>>
>>> This patch set provides support for configuring the RSS hash-key via the
>> ethtool interface.
>>>
>>> The patch set consists of:
>>> a) ethtool user-land patches
>>> b) ethtool kernel patch
>>> c) be2net patch that implements the ethtool hooks
>>
>> Hi,
>>
>> I would be happy to add support in setting the hash function in addition to
>> the hash key.
>>
>> Mellanox NIC's have support in 2 hash functions: Toplitz and XOR.
>>
>> Let me if you can add it to your patchset or would like me to send a patch on
>> top of yours to add it.
>
> I would prefer you to add the proposed changes on top my patchset. I'm working on the review comments currently and I will post the patchset once the patches are ready.
Ok,
I will send as soon as your patchset be applied.
Thanks,
Amir
prev parent reply other threads:[~2014-02-05 12:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 13:02 [PATCH 0/4] Patchset - Support for configurable RSS hash key Venkata Duvvuru
2014-01-18 3:01 ` David Miller
2014-02-02 16:10 ` Amir Vadai
2014-02-05 12:20 ` Venkata Duvvuru
2014-02-05 12:24 ` Amir Vadai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F22D8B.4000408@mellanox.com \
--to=amirv@mellanox$(echo .)com \
--cc=VenkatKumar.Duvvuru@Emulex$(echo .)Com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox