public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Toshiaki Makita <makita.toshiaki@lab•ntt.co.jp>
To: Cong Wang <cwang@twopensource•com>
Cc: Stephen Hemminger <stephen@networkplumber•org>,
	netdev <netdev@vger•kernel.org>
Subject: Re: Fw: [Bug 70071] New: Sending netconsole messages over a bridged network interface doesn't work anymore
Date: Thu, 06 Feb 2014 17:52:17 +0900	[thread overview]
Message-ID: <52F34D41.8000704@lab.ntt.co.jp> (raw)
In-Reply-To: <CAHA+R7Ork+gER_v=YhQCSDO9N=aokXiSiMUWwD3aMSv2YaZJ4g@mail.gmail.com>

(2014/02/06 15:49), Cong Wang wrote:
> On Wed, Feb 5, 2014 at 9:44 PM, Toshiaki Makita
> <makita.toshiaki@lab•ntt.co.jp> wrote:
>> Tested this patch with latest net-tree and netconsole works with it.
>> But I thinks it is better to move that "if" to br_add_if() because if we
>> don't have npinfo, we don't have to alloc p->np in br_add_if(), right?
>>
> 
> Hmm, we shouldn't handle netpoll-specific code inside br_add_if(),
> we probably need the attached patch instead. Please give it
> a try, or I will test it tomorrow, it's too late here.
> 

I tested whether netconsole works and whether it can be built
with/without CONFIG_NET_POLL_CONTROLLER, and couldn't find any problem.
This looks good to me.

Thanks,
Toshiaki Makita

next prev parent reply	other threads:[~2014-02-06  8:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-05 21:15 Fw: [Bug 70071] New: Sending netconsole messages over a bridged network interface doesn't work anymore Stephen Hemminger
2014-02-06  0:36 ` Cong Wang
2014-02-06  3:58 ` Toshiaki Makita
2014-02-06  5:05   ` Cong Wang
2014-02-06  5:44     ` Toshiaki Makita
2014-02-06  6:49       ` Cong Wang
2014-02-06  8:52         ` Toshiaki Makita [this message]
2014-02-06 22:18           ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F34D41.8000704@lab.ntt.co.jp \
    --to=makita.toshiaki@lab$(echo .)ntt.co.jp \
    --cc=cwang@twopensource$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=stephen@networkplumber$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox