From: Shradha Shah <sshah@solarflare•com>
To: Paul Gortmaker <paul.gortmaker@windriver•com>
Cc: <netdev@vger•kernel.org>, <linux-net-drivers@solarflare•com>,
Jon Cooper <jcooper@solarflare•com>,
Ben Hutchings <bhutchings@solarflare•com>
Subject: Re: [PATCH-net] drivers/net: fix build warning in ethernet/sfc/tx.c
Date: Thu, 6 Feb 2014 16:59:59 +0000 [thread overview]
Message-ID: <52F3BF8F.4080506@solarflare.com> (raw)
In-Reply-To: <1391705112-27869-1-git-send-email-paul.gortmaker@windriver.com>
On 02/06/2014 04:45 PM, Paul Gortmaker wrote:
> Commit ee45fd92c739db5b7950163d91dfe5f016af6d24 ("sfc: Use TX PIO
> for sufficiently small packets") introduced the following warning:
>
> drivers/net/ethernet/sfc/tx.c: In function 'efx_enqueue_skb':
> drivers/net/ethernet/sfc/tx.c:432:1: warning: label 'finish_packet' defined but not used
>
> Stick the label inside the same #ifdef that the code which calls
> it uses. Note that this is only seen for arch that do not set
> ARCH_HAS_IOREMAP_WC, such as arm, mips, sparc, ..., as the others
> enable the write combining code and hence use the label.
>
> Cc: Jon Cooper <jcooper@solarflare•com>
> Cc: Ben Hutchings <bhutchings@solarflare•com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver•com>
Acked-by: Shradha Shah <sshah@solarflare•com>
> ---
> drivers/net/ethernet/sfc/tx.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c
> index c49d1fb16965..75d11fa4eb0a 100644
> --- a/drivers/net/ethernet/sfc/tx.c
> +++ b/drivers/net/ethernet/sfc/tx.c
> @@ -429,7 +429,9 @@ netdev_tx_t efx_enqueue_skb(struct efx_tx_queue *tx_queue, struct sk_buff *skb)
> }
>
> /* Transfer ownership of the skb to the final buffer */
> +#ifdef EFX_USE_PIO
> finish_packet:
> +#endif
> buffer->skb = skb;
> buffer->flags = EFX_TX_BUF_SKB | dma_flags;
>
>
next prev parent reply other threads:[~2014-02-06 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 16:45 [PATCH-net] drivers/net: fix build warning in ethernet/sfc/tx.c Paul Gortmaker
2014-02-06 16:59 ` Shradha Shah [this message]
2014-02-07 6:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F3BF8F.4080506@solarflare.com \
--to=sshah@solarflare$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=jcooper@solarflare$(echo .)com \
--cc=linux-net-drivers@solarflare$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paul.gortmaker@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox