Subject: Re: [Xen-devel] [PATCH V3 net-next 4/5] xen-netfront: Add support for multiple queues

From: David Vrabel <[email-masked]>
Date: Fri, 14 Feb 2014 18:11:45 +0000

On 14/02/14 17:35, Andrew J. Bennieston wrote:
> From: "Andrew J. Bennieston" <[email-masked]>
> 
> Build on the refactoring of the previous patch to implement multiple
> queues between xen-netfront and xen-netback.
> 
> Check XenStore for multi-queue support, and set up the rings and event
> channels accordingly.
> 
> Write ring references and event channels to XenStore in a queue
> hierarchy if appropriate, or flat when using only one queue.
> 
> Update the xennet_select_queue() function to choose the queue on which
> to transmit a packet based on the skb hash result.
[...]
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -57,6 +57,10 @@
>  #include <xen/interface/memory.h>
>  #include <xen/interface/grant_table.h>
>  
> +/* Module parameters */
> +unsigned int xennet_max_queues;
> +module_param(xennet_max_queues, uint, 0644);

Module parameter should have some documentation with MODULE_PARAM_DESC()
or similar.

Otherwise,

Reviewed-by: David Vrabel <[email-masked]>

David