Subject: Re: [net-next v2 3/3] cfg80211: add MPLS and 802.21 classification

From: Arend van Spriel <[email-masked]>
Date: Tue, 18 Feb 2014 18:30:30 +0100

On 02/17/2014 08:06 PM, David Miller wrote:
> From: "Kretschmer, Mathias" <[email-masked]>
> Date: Mon, 17 Feb 2014 17:34:34 +0000
> 
>> Thought so, as well. But it seems that skb->protocol is not properly
>> set when the packet originates from a packet socket.  And in our
>> case we cannot set it to a fixed etherType in the bind() call since
>> we use three different etherTypes on the same socket.
> 
> So many things break if the skb->protocol isn't set correctly that I
> would consider such SKBs mal-formed.

That was my take as well, but how does the kernel code consider this?

> You can specify the protocol number in the msghdr passed into the
> send.
> 

Regards,
Arend