From: Ben Dooks <ben.dooks@codethink•co.uk>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
Cc: netdev@vger•kernel.org, horms+renesas@verge•net.au,
linux-sh@vger•kernel.org, magnus@opensource•se,
linux-kernel@lists•codethink.co.uk
Subject: Re: [PATCH] sh_eth: call of_mdiobus_register() to register phys
Date: Tue, 18 Feb 2014 17:39:20 +0000 [thread overview]
Message-ID: <53039AC8.1010802@codethink.co.uk> (raw)
In-Reply-To: <5303A26D.9050301@cogentembedded.com>
On 18/02/14 18:11, Sergei Shtylyov wrote:
> Hello.
>
> On 02/18/2014 07:00 PM, Ben Dooks wrote:
>
>>>>>> If the sh_eth device is registered using OF, then the driver
>
>>>>> Which is not supported yet as my DT patch hasn't been merged.
>>>>> This patch seems somewhat premature.
>
>>>> I've got your OF patches in my local tree to test with, this
>>>> is what I found during that testing.
>
>>> The issue is that I didn't post my v3 patch to netdev due to
>>> net-next.git repo being closed at this moment and DaveM not wanting to
>>> see any patch targeted to it during this time. I've now posted v4 of my
>>> Ether DT patch to netdev.
>
>> Ok, I will look for these tomorrow.
>
> No significant changes there...
>
>>>>>> should call of_mdiobus_register() to register any PHYs connected
>>>>>> to the system.
>
>>>>> That's not necessary (but good to have).
>
>>>> Well, it is necessary if you then want any PHYS bound to
>>>> the device to have their OF information to hand,
>
>>> Ether DT support worked for me without this fragment, at least.
>
>> Yes, it just that the PHY is not being linked to the relevant
>> OF node. The PHY gets bound, it will not be able to find the
>> DT info passed.
>
> With no DT support in the PHY driver, I don't see how it matters.
> Perhaps it has to do with your "init-regs" prop patch though...
Yes, or if we add some other properties to the PHY node to say
how to initialise the registers, such as if the PHY node had.
I am going to look in to adding led<name> initialisers to the
PHY node in case people do not like my init-regs patch.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
prev parent reply other threads:[~2014-02-18 17:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 15:28 [PATCH] sh_eth: call of_mdiobus_register() to register phys Ben Dooks
2014-02-17 16:40 ` Sergei Shtylyov
2014-02-17 15:46 ` Ben Dooks
2014-02-17 16:44 ` [Linux-kernel] " Ben Dooks
2014-02-18 16:38 ` Sergei Shtylyov
2014-02-18 16:00 ` Ben Dooks
2014-02-18 18:11 ` Sergei Shtylyov
2014-02-18 17:39 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53039AC8.1010802@codethink.co.uk \
--to=ben.dooks@codethink$(echo .)co.uk \
--cc=horms+renesas@verge$(echo .)net.au \
--cc=linux-kernel@lists$(echo .)codethink.co.uk \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=magnus@opensource$(echo .)se \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox