From: Casey Leedom <leedom@chelsio•com>
To: Florian Fainelli <f.fainelli@gmail•com>
Cc: Steve Wise <swise@opengridcomputing•com>,
Hariprasad Shenai <hariprasad@chelsio•com>,
netdev <netdev@vger•kernel.org>,
David Miller <davem@davemloft•net>,
dm@chelsio•com, nirranjan@chelsio•com, kumaras@chelsio•com,
santosh@chelsio•com
Subject: Re: [PATCH net-next 1/8] cxgb4: Add support to recognize 40G links
Date: Thu, 20 Feb 2014 11:16:26 -0800 [thread overview]
Message-ID: <5306548A.2090406@chelsio.com> (raw)
In-Reply-To: <CAGVrzcbb-7sQqHyf8SS8-mUyD+LM==Z6r3Zy1rFQ72WHFveMcQ@mail.gmail.com>
On 02/20/14 11:00, Florian Fainelli wrote:
> 2014-02-20 10:07 GMT-08:00 Casey Leedom <leedom@chelsio•com>:
>> On 02/19/14 13:12, Steve Wise wrote:
>>>
>>> You probably should add SPEED_40000 to include/uapi/linux/ethtool.h as
>>> part of this series.
>>
>> I'm ~pretty sure~ that the "word on the street" was that the community
>> wanted to get away from the SPEED_XXX symbols since they simply represented
>> the values XXX. Thus they didn't offer any real symbolic isolation from
>> weird constants, etc. I believe that the old SPEED_XXX values were left in
>> place in order to avoid making tons of changes everywhere ...
> Not quite sure where and when you heard that, it seems a little
> disturbing to add a comment in this patch saying "this I how I should
> fix things" and not do them, especially when this is a one-liner.
> Having a well defined constant is easier to grep than having the
> open-coded 40000 constant which will lead to false positives
> throughout the tree.
Like I said, it was a vague memory at best from over a year ago. I
seem to remember someone on our team trying to push SPEED_40000 into the
kernel and getting rebuffed. Perhaps I didn't have enough coffee that day.
In any case, I personally like the idea of SPEED_40000 for exactly
the reason you offer: I can search for it meaningfully. So If my vague
memory is wrong, yeay!
Casey
> --
> Florian
next prev parent reply other threads:[~2014-02-20 19:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 12:26 [PATCH net-next 0/8] Adds support for Chelsio T5 40G adapter and Misc. fixes Hariprasad Shenai
2014-02-18 12:26 ` [PATCH net-next 1/8] cxgb4: Add support to recognize 40G links Hariprasad Shenai
2014-02-19 21:12 ` Steve Wise
2014-02-20 18:07 ` Casey Leedom
2014-02-20 19:00 ` Florian Fainelli
2014-02-20 19:16 ` Casey Leedom [this message]
2014-02-21 4:37 ` Kumar Sanghvi
2014-02-21 18:49 ` Casey Leedom
2014-02-22 23:59 ` Ben Hutchings
2014-02-18 12:26 ` [PATCH net-next 2/8] cxgb4: Print adapter VPD Part Number instead of Engineering Change field Hariprasad Shenai
2014-02-18 12:26 ` [PATCH net-next 3/8] cxgb4: Allow >10G ports to have multiple queues Hariprasad Shenai
2014-02-18 12:26 ` [PATCH net-next 4/8] cxgb4: LE-Workaround is not atomic in firmware Hariprasad Shenai
2014-02-18 12:26 ` [PATCH net-next 5/8] cxgb4: Query firmware for T5 ULPTX MEMWRITE DSGL capabilities Hariprasad Shenai
2014-02-18 12:26 ` [PATCH net-next 6/8] cxgb4: Remove unused registers and add missing ones Hariprasad Shenai
2014-02-18 12:26 ` [PATCH net-next 7/8] cxgb4: Don't assume LSO only uses SGL path in t4_eth_xmit() Hariprasad Shenai
2014-02-18 12:26 ` [PATCH net-next 8/8] cxgb4: Add more PCI device ids Hariprasad Shenai
2014-02-18 21:24 ` [PATCH net-next 0/8] Adds support for Chelsio T5 40G adapter and Misc. fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5306548A.2090406@chelsio.com \
--to=leedom@chelsio$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dm@chelsio$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hariprasad@chelsio$(echo .)com \
--cc=kumaras@chelsio$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nirranjan@chelsio$(echo .)com \
--cc=santosh@chelsio$(echo .)com \
--cc=swise@opengridcomputing$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox