Subject: Re: [net-next v2 1/3] net: bcmgenet: drop checks on priv->phydev

From: Sergei Shtylyov <[email-masked]>
Date: Tue, 25 Feb 2014 20:09:56 +0400

Hello.

On 25-02-2014 4:56, Florian Fainelli wrote:

> Drop all the checks on priv->phydev since we will refuse probing the
> driver if we cannot attach to a PHY device. Drop all checks on
> priv->phydev. This also fixes some smatch issues reported by Dan
> Carpenter.

> Reported-by: Dan Carpenter <[email-masked]>
> Signed-off-by: Florian Fainelli <[email-masked]>
> ---
> Changes in v2:
> - addressed Sergei's comment re-align phy_mac_interrupt and drop
>    useless parenthesis

>   drivers/net/ethernet/broadcom/genet/bcmgenet.c | 17 ++++++-----------
>   1 file changed, 6 insertions(+), 11 deletions(-)

> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> index 192069d..5856457 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
[...]
> @@ -1811,9 +1810,8 @@ static void bcmgenet_irq_task(struct work_struct *work)
>   	/* Link UP/DOWN event */
>   	if ((priv->hw_params->flags & GENET_HAS_MDIO_INTR) &&
>   		(priv->irq0_stat & (UMAC_IRQ_LINK_UP|UMAC_IRQ_LINK_DOWN))) {
> -		if (priv->phydev)
> -			phy_mac_interrupt(priv->phydev,
> -				(priv->irq0_stat & UMAC_IRQ_LINK_UP));
> +		phy_mac_interrupt(priv->phydev,
> +			priv->irq0_stat & UMAC_IRQ_LINK_UP);

    I still don't see this line aligned as needed, to start under 'priv->phydev'.

WBR, Sergei