From: Giuseppe CAVALLARO <peppe.cavallaro@st•com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>,
<netdev@vger•kernel.org>
Subject: Re: [PATCH (net.git) 1/6] stmmac: disable at run-time the EEE if not supported
Date: Wed, 26 Feb 2014 07:39:30 +0100 [thread overview]
Message-ID: <530D8C22.2020703@st.com> (raw)
In-Reply-To: <530CC4E4.40301@cogentembedded.com>
On 2/25/2014 5:29 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 25-02-2014 13:58, Giuseppe Cavallaro wrote:
>
>> This patch is to disable the EEE (so HW and timers)
>> for example when the phy communicates that the EEE
>> can be supported anymore.
>
>> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st•com>
>> ---
>> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 24
>> ++++++++++++++++----
>> 1 files changed, 19 insertions(+), 5 deletions(-)
>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> index 078ad0e..dc89dc3 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> [...]
>> @@ -2204,7 +2219,6 @@ static int stmmac_poll(struct napi_struct *napi,
>> int budget)
>> static void stmmac_tx_timeout(struct net_device *dev)
>> {
>> struct stmmac_priv *priv = netdev_priv(dev);
>> -
>
> Why? Empty line is needed here, after declaration.
yes out-of-scope in this patch. I'll fix it and resend all
BR
Peppe
>
>> /* Clear Tx resources and restart transmitting again */
>> stmmac_tx_err(priv);
>> }
>
> WBR, Sergei
>
>
>
prev parent reply other threads:[~2014-02-26 6:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 9:58 [PATCH (net.git) 1/6] stmmac: disable at run-time the EEE if not supported Giuseppe Cavallaro
2014-02-25 9:58 ` [PATCH (net.git) 2/6] stmmac: fix and better tune the default buffer sizes Giuseppe Cavallaro
2014-02-25 9:58 ` [PATCH (net.git) 3/6] stmmac: dwmac-sti: fix broken STiD127 compatibility Giuseppe Cavallaro
2014-02-25 9:58 ` [PATCH (net.git) 4/6] stmmac: dwmac-sti: remove useless tx_retime_srcs Giuseppe Cavallaro
2014-02-25 9:58 ` [PATCH (net.git) 5/6] stmmac: remove useless check in the stmmac_tx_clean Giuseppe Cavallaro
2014-02-25 9:58 ` [PATCH (net.git) 6/6] stmmac: fix chained mode Giuseppe Cavallaro
2014-02-25 16:29 ` [PATCH (net.git) 1/6] stmmac: disable at run-time the EEE if not supported Sergei Shtylyov
2014-02-26 6:39 ` Giuseppe CAVALLARO [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530D8C22.2020703@st.com \
--to=peppe.cavallaro@st$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox