From: Ben Dooks <ben.dooks@codethink•co.uk>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
Cc: netdev@vger•kernel.org, linux-sh@vger•kernel.org,
nobuhiro.iwamatsu.yj@renesas•com, magnus.damn@opensource•se,
horms@verge•net.au
Subject: Re: [PATCH] sh_net: runtime pm wrap mdio read and write
Date: Wed, 26 Feb 2014 18:25:01 +0000 [thread overview]
Message-ID: <530E317D.3070807@codethink.co.uk> (raw)
In-Reply-To: <530E3EBC.5060408@cogentembedded.com>
On 26/02/14 19:21, Sergei Shtylyov wrote:
> On 02/26/2014 07:48 PM, Ben Dooks wrote:
>
>> On the R8A7790, if the device has been suspended by pm_runtime
>> and the MII code tries to access the bus then there is a possiblity
>
> s/possiblity/possibility/.
ta, will fix.
>> that it will fail to read any data from the MII bus.
>
>> Change the MDIO read and write calls to be wrappered by calls to
>
> s/wrappered/wrapped/.
ta.
>> pm_runtime_{get,put}_sync so that the device will be enabled during
>> these calls. It is put here to avoid having to enable and disable
>> the clock for every bit that is sent by the MII bit-banging code.
>
>> This has been exposed by the change to using OF and a fix to enable
>> the pm_runtime clock management which seems to have been broken for
>> some time for the device-tree booted Renesas kernels.
>
> What fix to enable run-time PM are you talking about?
building drivers/sh/pm_runtime.c for the multiplatform case.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2014-02-26 18:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 16:48 [PATCH] sh_net: runtime pm wrap mdio read and write Ben Dooks
2014-02-26 19:21 ` Sergei Shtylyov
2014-02-26 18:25 ` Ben Dooks [this message]
2014-02-26 19:23 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530E317D.3070807@codethink.co.uk \
--to=ben.dooks@codethink$(echo .)co.uk \
--cc=horms@verge$(echo .)net.au \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=magnus.damn@opensource$(echo .)se \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas$(echo .)com \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox