From: Nicolas Dichtel <nicolas.dichtel@6wind•com>
To: Steffen Klassert <steffen.klassert@secunet•com>, netdev@vger•kernel.org
Cc: Christophe Gouault <christophe.gouault@6wind•com>
Subject: Re: [PATCH RFC 06/12] vti6: Remove dst_entry caching
Date: Mon, 03 Mar 2014 11:58:18 +0100 [thread overview]
Message-ID: <5314604A.4050905@6wind.com> (raw)
In-Reply-To: <1393583483-12480-7-git-send-email-steffen.klassert@secunet.com>
Le 28/02/2014 11:31, Steffen Klassert a écrit :
> Unlike ip6_tunnel, vti6 can lookup multiple different dst entries,
> dependent of the configured xfrm states. Therefore it does not make
> sense to cache a dst_entry.
>
> Signed-off-by: Steffen Klassert <steffen.klassert@secunet•com>
> ---
> net/ipv6/ip6_vti.c | 44 +++++++++++++++++++-------------------------
> 1 file changed, 19 insertions(+), 25 deletions(-)
>
> diff --git a/net/ipv6/ip6_vti.c b/net/ipv6/ip6_vti.c
> index 8649143..3f337c7 100644
> --- a/net/ipv6/ip6_vti.c
> +++ b/net/ipv6/ip6_vti.c
> @@ -278,7 +278,6 @@ static void vti6_dev_uninit(struct net_device *dev)
> RCU_INIT_POINTER(ip6n->tnls_wc[0], NULL);
> else
> vti6_tnl_unlink(ip6n, t);
> - ip6_tnl_dst_reset(t);
> dev_put(dev);
> }
>
> @@ -356,11 +355,10 @@ vti6_addr_conflict(const struct ip6_tnl *t, const struct ipv6hdr *hdr)
> **/
> static int vti6_xmit(struct sk_buff *skb, struct net_device *dev)
> {
> - struct net *net = dev_net(dev);
> struct ip6_tnl *t = netdev_priv(dev);
> struct net_device_stats *stats = &t->dev->stats;
> - struct dst_entry *dst = NULL, *ndst = NULL;
> - struct flowi6 fl6;
> + struct dst_entry *dst = skb_dst(skb);
> + struct flowi fl;
> struct ipv6hdr *ipv6h = ipv6_hdr(skb);
> struct net_device *tdev;
> int err = -1;
> @@ -369,21 +367,19 @@ static int vti6_xmit(struct sk_buff *skb, struct net_device *dev)
> !ip6_tnl_xmit_ctl(t) || vti6_addr_conflict(t, ipv6h))
> return err;
>
> - dst = ip6_tnl_dst_check(t);
> - if (!dst) {
> - memcpy(&fl6, &t->fl.u.ip6, sizeof(fl6));
> + memset(&fl, 0, sizeof(fl));
> + skb->mark = be32_to_cpu(t->parms.o_key);
> + xfrm_decode_session(skb, &fl, AF_INET6);
>
> - ndst = ip6_route_output(net, NULL, &fl6);
> + if (!dst)
> + goto tx_err_link_failure;
>
> - if (ndst->error)
> - goto tx_err_link_failure;
> - ndst = xfrm_lookup(net, ndst, flowi6_to_flowi(&fl6), NULL, 0);
> - if (IS_ERR(ndst)) {
> - err = PTR_ERR(ndst);
> - ndst = NULL;
> - goto tx_err_link_failure;
> - }
> - dst = ndst;
> + dst_hold(dst);
> + dst = xfrm_lookup(t->net, dst, &fl, NULL, 0);
> + if (IS_ERR(dst)) {
> + err = PTR_ERR(dst);
> + dst = NULL;
> + goto tx_err_link_failure;
> }
>
> if (!dst->xfrm || dst->xfrm->props.mode != XFRM_MODE_TUNNEL)
> @@ -399,21 +395,19 @@ static int vti6_xmit(struct sk_buff *skb, struct net_device *dev)
> }
>
>
> - skb_dst_drop(skb);
> - skb_dst_set_noref(skb, dst);
> + memset(IP6CB(skb), 0, sizeof(*IP6CB(skb)));
> + skb_scrub_packet(skb, !net_eq(t->net, dev_net(dev)));
> + skb_dst_set(skb, dst);
> + skb->dev = skb_dst(skb)->dev;
>
> ip6tunnel_xmit(skb, dev);
> - if (ndst) {
> - dev->mtu = dst_mtu(ndst);
> - ip6_tnl_dst_store(t, ndst);
> - }
>
> return 0;
> tx_err_link_failure:
> stats->tx_carrier_errors++;
> dst_link_failure(skb);
> tx_err_dst_release:
> - dst_release(ndst);
> + dst_release(dst);
> return err;
> }
>
> @@ -997,7 +991,7 @@ static int __init vti6_tunnel_init(void)
> if (err < 0)
> goto out_pernet;
>
> - err = xfrm6_mode_tunnel_input_register(&vti6_handler);
> + err = xfrm6_mode_tunnel_input_register(&vti6_handler);
There is no difference in this line, except the space after the tab.
> if (err < 0) {
> pr_err("%s: can't register vti6\n", __func__);
> goto out;
>
next prev parent reply other threads:[~2014-03-03 10:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 10:31 [PATCH RFC 0/12] vti6: prepare namespace and interfamily support Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 01/12] xfrm: Introduce xfrm_input_afinfo to access the the callbacks properly Steffen Klassert
2014-03-03 1:09 ` David Miller
2014-03-05 12:24 ` Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 02/12] xfrm6: Add IPsec protocol multiplexer Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 03/12] esp6: Use the IPsec protocol multiplexer API Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 04/12] ah6: " Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 05/12] ipcomp6: " Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 06/12] vti6: Remove dst_entry caching Steffen Klassert
2014-03-03 10:58 ` Nicolas Dichtel [this message]
2014-02-28 10:31 ` [PATCH RFC 07/12] vti6: Remove caching of flow informations Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 08/12] vti6: Update the ipv6 side to use it's own receive hook Steffen Klassert
2014-03-03 1:12 ` David Miller
2014-02-28 10:31 ` [PATCH RFC 09/12] xfrm6: Remove xfrm_tunnel_notifier Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 10/12] vti6: Support inter address family tunneling Steffen Klassert
2014-03-03 1:13 ` David Miller
2014-02-28 10:31 ` [PATCH RFC 11/12] vti6: Check the tunnel endpoints of the xfrm state and the vti interface Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 12/12] vti6: Enable namespace changing Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5314604A.4050905@6wind.com \
--to=nicolas.dichtel@6wind$(echo .)com \
--cc=christophe.gouault@6wind$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=steffen.klassert@secunet$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox