Subject: Re: [PATCHv3 net-next 03/31] cxgb4: Rectify emitting messages about SGE Ingress DMA channels being potentially stuck

From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/[email-masked]>
Date: Tue, 04 Mar 2014 23:22:12 +0300

Hello.

On 03/04/2014 08:43 PM, Joe Perches wrote:

>> From: Kumar Sanghvi <[email-masked]>

>> Based on original work by Casey Leedom <[email-masked]>

> trivial comments:

>> diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/ethernet/chelsio/cxgb4/sge.c

>> @@ -2031,21 +2041,65 @@ static void sge_rx_timer_cb(unsigned long data)
> []
>> +		if (idma_same_state_cnt[i] < s->idma_1s_thresh) {
>> +			if (s->idma_stalled[i] >= SGE_IDMA_WARN_THRESH)
>> +				CH_WARN(adap, "SGE idma%d, queue%u,resumed after %d sec",

> Missing terminating '\n', probably better as:

> 				CH_WARN(adap, "SGE idma%d, queue%u, resumed after %d sec\n",

>> +		CH_WARN(adap, "SGE idma%u, queue%u, maybe stuck state%u %dsecs"
>> +			" (debug0=%#x, debug11=%#x)\n",

> Probably better with the format coalesced:

> 		CH_WARN(adap, "SGE idma%u, queue%u, maybe stuck state%u %dsecs (debug0=%#x, debug11=%#x)\n",

    Surely better, as otherwise it shouldn't pass scripts/checkpatch.pl.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email-masked]
More majordomo info at  http://vger.kernel.org/majordomo-info.html