From: Giuseppe CAVALLARO <peppe.cavallaro@st•com>
To: David Laight <David.Laight@ACULAB•COM>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH (net.git) 2/4] stmmac: fix and better tune the default buffer sizes
Date: Wed, 5 Mar 2014 11:26:10 +0100 [thread overview]
Message-ID: <5316FBC2.6060501@st.com> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D0F6D14A3@AcuExch.aculab.com>
On 3/5/2014 10:33 AM, David Laight wrote:
> From: Giuseppe CAVALLARO
>> Hello David
>>
>> Sorry, can you tell me what is the final your opinion about
>> this patch?
>>
>> I think that it not good to keep 4KiB as default and your main concern
>> was about the default buffer size that depended on VLAN ifconfig.
>>
>> So I could adopt 1536bytes as default and remove ifdef.
>
> If the rx buffer size has to match the mtu then the minimum
> size needs to be that for non-vlan packets.
>
> OTOH if the rx buffer size only has to be 'long enough' and
> a frame length check is done in software then you can always
> use the vlan length and save reconfig is someone enables vlans.
yes this is what I wanted to have.
> My real concern was that you were setting the minimum buffer
> size based on a vlan config option - which really didn't seem
> right at all.
ok, so I'll re-send a patch using as default 1536 and w/o surrounding
the code with ifdef (vlan).
thx
peppe
>
> David
>
>
>
>
>
next prev parent reply other threads:[~2014-03-05 10:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 10:35 [PATCH (net.git) 0/4 (v3)] stmmac fixes: EEE and chained mode Giuseppe Cavallaro
2014-02-27 10:35 ` [PATCH (net.git) 1/4] stmmac: disable at run-time the EEE if not supported Giuseppe Cavallaro
2014-02-27 10:35 ` [PATCH (net.git) 2/4] stmmac: fix and better tune the default buffer sizes Giuseppe Cavallaro
2014-02-27 10:51 ` David Laight
2014-02-27 13:03 ` Giuseppe CAVALLARO
2014-02-27 13:31 ` David Laight
2014-02-27 13:54 ` Giuseppe CAVALLARO
2014-03-04 7:20 ` Giuseppe CAVALLARO
2014-03-05 9:33 ` David Laight
2014-03-05 10:26 ` Giuseppe CAVALLARO [this message]
2014-02-27 13:34 ` Giuseppe CAVALLARO
2014-02-27 10:35 ` [PATCH (net.git) 3/4] stmmac: dwmac-sti: fix broken STiD127 compatibility Giuseppe Cavallaro
2014-02-27 10:35 ` [PATCH (net.git) 4/4] stmmac: fix chained mode Giuseppe Cavallaro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5316FBC2.6060501@st.com \
--to=peppe.cavallaro@st$(echo .)com \
--cc=David.Laight@ACULAB$(echo .)COM \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox