From: Ivan Vecera <ivecera@redhat•com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>,
netdev@vger•kernel.org
Cc: sathya.perla@emulex•com, subbu.seetharaman@emulex•com,
ajit.khaparde@emulex•com
Subject: Re: [PATCH net-next] be2net: do external loopback test only when it is requested
Date: Wed, 05 Mar 2014 11:56:16 +0100 [thread overview]
Message-ID: <531702D0.8020205@redhat.com> (raw)
In-Reply-To: <531634F1.4070109@cogentembedded.com>
On 03/04/2014 09:17 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 03/04/2014 09:04 PM, Ivan Vecera wrote:
>
>> Cc: sathya.perla@emulex•com
>> Cc: subbu.seetharaman@emulex•com
>> Cc: ajit.khaparde@emulex•com
>
>> Signed-off-by: Ivan Vecera <ivecera@redhat•com>
>> ---
>> drivers/net/ethernet/emulex/benet/be_ethtool.c | 9 ++++++---
>> 1 file changed, 6 insertions(+), 3 deletions(-)
>
>> diff --git a/drivers/net/ethernet/emulex/benet/be_ethtool.c
>> b/drivers/net/ethernet/emulex/benet/be_ethtool.c
>> index cf09d8f..957848f 100644
>> --- a/drivers/net/ethernet/emulex/benet/be_ethtool.c
>> +++ b/drivers/net/ethernet/emulex/benet/be_ethtool.c
>> @@ -809,9 +809,12 @@ be_self_test(struct net_device *netdev, struct
>> ethtool_test *test, u64 *data)
>> &data[1]) != 0) {
>> test->flags |= ETH_TEST_FL_FAILED;
>> }
>> - if (be_loopback_test(adapter, BE_ONE_PORT_EXT_LOOPBACK,
>> - &data[2]) != 0) {
>> - test->flags |= ETH_TEST_FL_FAILED;
>> + if (test->flags & ETH_TEST_FL_EXTERNAL_LB) {
>> + if (be_loopback_test(adapter, BE_ONE_PORT_EXT_LOOPBACK,
>> + &data[2]) != 0) {
>> + test->flags |= ETH_TEST_FL_FAILED;
>> + }
>
> {} not needed here, according to Documentation/CodingStyle. I'm
> surprised scripts/checkpatch.pl passed, it used to catch those.
>
I wanted to preserve the same look as for other prior loopback
if-blocks. I will fix them all and resend v2.
Ivan
prev parent reply other threads:[~2014-03-05 10:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 18:04 [PATCH net-next] be2net: do external loopback test only when it is requested Ivan Vecera
2014-03-04 19:03 ` Ajit Khaparde
2014-03-04 20:17 ` Sergei Shtylyov
2014-03-05 10:56 ` Ivan Vecera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531702D0.8020205@redhat.com \
--to=ivecera@redhat$(echo .)com \
--cc=ajit.khaparde@emulex$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sathya.perla@emulex$(echo .)com \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=subbu.seetharaman@emulex$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox