From: Nikolay Aleksandrov <nikolay@redhat•com>
To: Stephen Hemminger <stephen@networkplumber•org>,
Jay Vosburgh <fubar@us•ibm.com>,
Andy Gospodarek <andy@greyhouse•net>,
Veaceslav Falico <vfalico@redhat•com>,
David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH net-next 2/2] bonding: options handling cleanup
Date: Wed, 05 Mar 2014 12:39:09 +0100 [thread overview]
Message-ID: <53170CDD.4040202@redhat.com> (raw)
In-Reply-To: <20140304163644.432f60d0@nehalam.linuxnetplumber.net>
On 03/05/2014 01:36 AM, Stephen Hemminger wrote:
> Make local functions static (ie. only used in bond_options.c)
> Make bond options parsing tables constant.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber•org>
>
>
> ---
> drivers/net/bonding/bond_main.c | 3
> drivers/net/bonding/bond_options.c | 190 ++++++++++++++++++++++++-------------
> drivers/net/bonding/bond_options.h | 57 +----------
> drivers/net/bonding/bond_sysfs.c | 16 +--
> drivers/net/bonding/bonding.h | 2
> 5 files changed, 141 insertions(+), 127 deletions(-)
>
Hi Stephen,
Thanks for doing this, it was one of the items on my todo list for a long time.
However there're a few more places that need cleaning up after the patch is applied:
drivers/net/bonding//bond_options.c: In function ‘bond_opt_dep_print’:
drivers/net/bonding//bond_options.c:511:10: warning: assignment discards ‘const’
qualifier from pointer target type [enabled by default]
modeval = bond_opt_get_val(BOND_OPT_MODE, params->mode);
^
drivers/net/bonding//bond_options.c: In function ‘bond_opt_error_interpret’:
drivers/net/bonding//bond_options.c:540:10: warning: assignment discards ‘const’
qualifier from pointer target type [enabled by default]
minval = bond_opt_get_flags(opt, BOND_VALFLAG_MIN);
^
drivers/net/bonding//bond_options.c:541:10: warning: assignment discards ‘const’
qualifier from pointer target type [enabled by default]
maxval = bond_opt_get_flags(opt, BOND_VALFLAG_MAX);
^
drivers/net/bonding//bond_options.c: In function ‘__bond_opt_set’:
drivers/net/bonding//bond_options.c:589:9: warning: assignment discards ‘const’
qualifier from pointer target type [enabled by default]
retval = bond_opt_parse(opt, val);
^
drivers/net/bonding//bond_procfs.c: In function ‘bond_info_show_master’:
drivers/net/bonding//bond_procfs.c:79:10: warning: assignment discards ‘const’
qualifier from pointer target type [enabled by default]
optval = bond_opt_get_val(BOND_OPT_FAIL_OVER_MAC,
^
drivers/net/bonding//bond_procfs.c:88:10: warning: assignment discards ‘const’
qualifier from pointer target type [enabled by default]
optval = bond_opt_get_val(BOND_OPT_XMIT_HASH,
^
drivers/net/bonding//bond_procfs.c:99:11: warning: assignment discards ‘const’
qualifier from pointer target type [enabled by default]
optval = bond_opt_get_val(BOND_OPT_PRIMARY_RESELECT,
^
drivers/net/bonding//bond_procfs.c:144:10: warning: assignment discards ‘const’
qualifier from pointer target type [enabled by default]
optval = bond_opt_get_val(BOND_OPT_AD_SELECT,
next prev parent reply other threads:[~2014-03-05 11:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 0:34 [PATCH net-next 1/2] bonding: remove dead code Stephen Hemminger
2014-03-05 0:36 ` [PATCH net-next 2/2] bonding: options handling cleanup Stephen Hemminger
2014-03-05 11:39 ` Nikolay Aleksandrov [this message]
2014-03-06 21:09 ` David Miller
2014-03-05 1:34 ` [PATCH net-next 1/2] bonding: remove dead code Ding Tianhong
2014-03-06 21:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53170CDD.4040202@redhat.com \
--to=nikolay@redhat$(echo .)com \
--cc=andy@greyhouse$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=fubar@us$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
--cc=vfalico@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox