From: Ding Tianhong <dingtianhong@huawei•com>
To: Veaceslav Falico <vfalico@redhat•com>, <netdev@vger•kernel.org>
Cc: Thomas Glanzmann <thomas@glanzmann•de>,
Jay Vosburgh <fubar@us•ibm.com>,
Andy Gospodarek <andy@greyhouse•net>
Subject: Re: [PATCH net-next] bonding: make slave status notifications GFP_ATOMIC
Date: Thu, 6 Mar 2014 10:02:06 +0800 [thread overview]
Message-ID: <5317D71E.7080401@huawei.com> (raw)
In-Reply-To: <1394025353-5496-1-git-send-email-vfalico@redhat.com>
On 2014/3/5 21:15, Veaceslav Falico wrote:
> Currently we're using GFP_KERNEL, however there are some path(s) where we
> can hold some spinlocks, specifically bond->curr_slave_lock:
>
> [ 4.722916] BUG: sleeping function called from invalid context at mm/slub.c:965
> [ 4.724438] in_atomic(): 1, irqs_disabled(): 0, pid: 940, name: ifup-eth
> [ 4.726034] 5 locks held by ifup-eth/940:
> ...snip...
> [ 4.734646] #4: (&bond->curr_slave_lock){+...+.}, at: [<ffffffffa00badc6>] bond_enslave+0xda6/0xdd0 [bonding]
> ...snip...
> [ 4.759081] [<ffffffffa00b6f11>] bond_change_active_slave+0x191/0x3b0 [bonding]
> [ 4.760917] [<ffffffffa00b7227>] bond_select_active_slave+0xf7/0x1d0 [bonding]
> [ 4.762751] [<ffffffffa00badce>] bond_enslave+0xdae/0xdd0 [bonding]
> ...snip...
>
> As it's out of hot path and is a really rare event - change the gfp_t flags
> to GFP_ATOMIC to avoid sleeping under spinlock.
>
> CC: Thomas Glanzmann <thomas@glanzmann•de>
> CC: Ding Tianhong <dingtianhong@huawei•com>
> CC: Jay Vosburgh <fubar@us•ibm.com>
> CC: Andy Gospodarek <andy@greyhouse•net>
> Signed-off-by: Veaceslav Falico <vfalico@redhat•com>
> ---
> drivers/net/bonding/bonding.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/bonding/bonding.h b/drivers/net/bonding/bonding.h
> index 4303628..4cd451d 100644
> --- a/drivers/net/bonding/bonding.h
> +++ b/drivers/net/bonding/bonding.h
> @@ -292,7 +292,7 @@ static inline void bond_set_active_slave(struct slave *slave)
> {
> if (slave->backup) {
> slave->backup = 0;
> - rtmsg_ifinfo(RTM_NEWLINK, slave->dev, 0, GFP_KERNEL);
> + rtmsg_ifinfo(RTM_NEWLINK, slave->dev, 0, GFP_ATOMIC);
> }
> }
>
> @@ -300,7 +300,7 @@ static inline void bond_set_backup_slave(struct slave *slave)
> {
> if (!slave->backup) {
> slave->backup = 1;
> - rtmsg_ifinfo(RTM_NEWLINK, slave->dev, 0, GFP_KERNEL);
> + rtmsg_ifinfo(RTM_NEWLINK, slave->dev, 0, GFP_ATOMIC);
> }
> }
>
Acked-by: Ding Tianhong <dingtianhong@huawei•com>
>
next prev parent reply other threads:[~2014-03-06 2:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 13:15 [PATCH net-next] bonding: make slave status notifications GFP_ATOMIC Veaceslav Falico
2014-03-06 2:02 ` Ding Tianhong [this message]
2014-03-06 13:22 ` Veaceslav Falico
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5317D71E.7080401@huawei.com \
--to=dingtianhong@huawei$(echo .)com \
--cc=andy@greyhouse$(echo .)net \
--cc=fubar@us$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=thomas@glanzmann$(echo .)de \
--cc=vfalico@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox