From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Alexander Aring <alex.aring@gmail•com>
Cc: alex.bluesman.smirnov@gmail•com, dbaryshkov@gmail•com,
linux-zigbee-devel@lists•sourceforge.net, netdev@vger•kernel.org
Subject: Re: [PATCH net-next 1/2] 6lowpan: reassembly: fix return of init function
Date: Thu, 06 Mar 2014 17:30:38 +0400 [thread overview]
Message-ID: <5318787E.9000105@cogentembedded.com> (raw)
In-Reply-To: <20140306054437.GA13676@omega>
Hello.
On 06-03-2014 9:44, Alexander Aring wrote:
>>> This patch adds a missing return after fragmentation init. Otherwise we
>>> register a sysctl interface and deregister it afterwards which makes no
>>> sense.
>>> Signed-off-by: Alexander Aring <alex.aring@gmail•com>
>>> ---
>>> net/ieee802154/reassembly.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>
>>> diff --git a/net/ieee802154/reassembly.c b/net/ieee802154/reassembly.c
>>> index 4511fc2..59db7b5 100644
>>> --- a/net/ieee802154/reassembly.c
>>> +++ b/net/ieee802154/reassembly.c
>>> @@ -550,6 +550,8 @@ int __init lowpan_net_frag_init(void)
>>> lowpan_frags.frag_expire = lowpan_frag_expire;
>>> lowpan_frags.secret_interval = 10 * 60 * HZ;
>>> inet_frags_init(&lowpan_frags);
>>> +
>>> + return 0;
>> Perhaps 'goto out' for "consistency" with the code above? (I don't know
>> why they used "goto out' in the first place.)
> ok, thanks, I will remove the "goto out" and will replace it with a
> "return 0" if you are fine with that.
You can't replace it with "return 0", only with "return ret".
> - Alex
WBR, Sergei
next prev parent reply other threads:[~2014-03-06 13:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 20:43 [PATCH net-next 0/2] 6lowpan: fixes for new reassembly implementation Alexander Aring
[not found] ` <1394052211-6976-1-git-send-email-alex.aring-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-03-05 20:43 ` [PATCH net-next 1/2] 6lowpan: reassembly: fix return of init function Alexander Aring
2014-03-05 22:04 ` Sergei Shtylyov
2014-03-06 5:44 ` Alexander Aring
2014-03-06 13:30 ` Sergei Shtylyov [this message]
2014-03-05 20:43 ` [PATCH net-next 2/2] 6lowpan: reassembly: fix kernel oops while unloading Alexander Aring
2014-03-05 22:32 ` Florian Westphal
2014-03-06 6:09 ` Alexander Aring
2014-03-06 13:38 ` Florian Westphal
2014-03-06 16:36 ` Alexander Aring
2014-03-06 16:41 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5318787E.9000105@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=alex.aring@gmail$(echo .)com \
--cc=alex.bluesman.smirnov@gmail$(echo .)com \
--cc=dbaryshkov@gmail$(echo .)com \
--cc=linux-zigbee-devel@lists$(echo .)sourceforge.net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox