From: Ding Tianhong <dingtianhong@huawei•com>
To: David Miller <davem@davemloft•net>
Cc: <ben@decadent•org.uk>, <john.r.fastabend@intel•com>,
<kaber@trash•net>, <netdev@vger•kernel.org>,
<f.fainelli@gmail•com>
Subject: Re: [PATCH net-next] vlan: Fix lockdep warning when vlan dev handle notification
Date: Mon, 10 Mar 2014 10:08:35 +0800 [thread overview]
Message-ID: <531D1EA3.2060708@huawei.com> (raw)
In-Reply-To: <20140307.014932.157368387111603644.davem@davemloft.net>
On 2014/3/7 14:49, David Miller wrote:
> From: Ding Tianhong <dingtianhong@huawei•com>
> Date: Fri, 7 Mar 2014 09:55:25 +0800
>
>> But I think if I vconfig add eth2.20.30 50, the warning would happen
>> again, but till now I could not find any scene that use 3 vlan id on
>> a virtual device, so I think it is not a problem.
>
> My example was to show that you aren't really fixing the bug, but
> rather are papering over it.
>
> In that sense, it is a problem.
>
> I also happen to disagree with your assertion that a 3 layered
> VLAN is invalid, it is valid. And if we allow the configuration
> it shouldn't throw locking assertions.
>
>
OK, thanks for your advise. I would think and solve this problem once-again.
Regards
Ding
prev parent reply other threads:[~2014-03-10 2:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 14:13 [PATCH net-next] vlan: Fix lockdep warning when vlan dev handle notification Ding Tianhong
2014-03-06 19:51 ` David Miller
2014-03-07 1:55 ` Ding Tianhong
2014-03-07 6:49 ` David Miller
2014-03-10 2:08 ` Ding Tianhong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531D1EA3.2060708@huawei.com \
--to=dingtianhong@huawei$(echo .)com \
--cc=ben@decadent$(echo .)org.uk \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=john.r.fastabend@intel$(echo .)com \
--cc=kaber@trash$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox