From: Michal Simek <monstr@monstr•eu>
To: Marc Kleine-Budde <mkl@pengutronix•de>
Cc: Appana Durga Kedareswara Rao <appana.durga.rao@xilinx•com>,
"linux-can@vger•kernel.org" <linux-can@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"devicetree@vger•kernel.org" <devicetree@vger•kernel.org>,
"robh+dt@kernel•org" <robh+dt@kernel•org>,
"grant.likely@linaro•org" <grant.likely@linaro•org>,
Michal Simek <michals@xilinx•com>,
"wg@grandegger•com" <wg@grandegger•com>,
"fengguang.wu@intel•com" <fengguang.wu@intel•com>
Subject: Re: [PATCH v5] can: xilinx CAN controller support.
Date: Wed, 12 Mar 2014 11:01:44 +0100 [thread overview]
Message-ID: <53203088.2070605@monstr.eu> (raw)
In-Reply-To: <531F0636.4050608@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1671 bytes --]
On 03/11/2014 01:48 PM, Marc Kleine-Budde wrote:
> On 03/11/2014 01:34 PM, Appana Durga Kedareswara Rao wrote:
>
>>>> diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig index
>>>> 9e7d95d..b180239 100644
>>>> --- a/drivers/net/can/Kconfig
>>>> +++ b/drivers/net/can/Kconfig
>>>> @@ -125,6 +125,13 @@ config CAN_GRCAN
>>>> endian syntheses of the cores would need some modifications on
>>>> the hardware level to work.
>>>>
>>>> +config CAN_XILINXCAN
>>>> + tristate "Xilinx CAN"
>>>> + depends on ARCH_ZYNQ || MICROBLAZE
>>>
>>> Is Zynq multiarch already?
>> Discussions are going on this
>> So the final thing that Fengguang ( fengguang.wu@intel•com)
>> Proposed is
>> config CAN_XILINX
>> tristate "Xilinx CAN"
>> depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST
>> depends on COMMON_CLK && HAS_MMIO # whatever you need for other architectures
>
>> Are you Ok for this?
>
> You have to fill the 2nd depends on with some sane values, though.
This should be that one
config CAN_XILINX
tristate "Xilinx CAN"
depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST
depends on COMMON_CLK && HAS_IOMEM
Is there any driver which is in CAN which not use MMIO accesses?
If not, maybe we should just add dependency to
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2014-03-12 10:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 13:20 [PATCH v5] can: xilinx CAN controller support Kedareswara rao Appana
[not found] ` <5254bfec-c6fd-4681-a34d-706d51e60fbb-+Ck8Kgl/v0+XHCJdrdq+zrjjLBE8jN/0@public.gmane.org>
2014-03-04 23:51 ` Sören Brinkmann
2014-03-05 6:58 ` Oliver Hartkopp
[not found] ` <5316CB29.7040200-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org>
2014-03-05 7:04 ` Appana Durga Kedareswara Rao
[not found] ` <20140304235115.GN13293@xsjandreislx>
2014-03-05 7:03 ` Appana Durga Kedareswara Rao
2014-03-10 14:57 ` Marc Kleine-Budde
2014-03-10 15:04 ` Michal Simek
2014-03-10 15:10 ` Marc Kleine-Budde
2014-03-10 15:15 ` Arnd Bergmann
2014-03-10 15:26 ` Michal Simek
2014-03-11 4:45 ` Fengguang Wu
2014-03-11 9:38 ` Michal Simek
2014-03-13 11:21 ` Fengguang Wu
2014-03-11 12:34 ` Appana Durga Kedareswara Rao
2014-03-11 12:48 ` Marc Kleine-Budde
2014-03-11 14:08 ` Appana Durga Kedareswara Rao
[not found] ` <a99feda0-7463-4781-bb73-90b99e65b014-QhSrsHip19sNTaRkHJHP0bjjLBE8jN/0@public.gmane.org>
2014-03-11 14:31 ` Marc Kleine-Budde
[not found] ` <531F1E30.4040203-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-03-12 10:18 ` Michal Simek
2014-03-12 16:18 ` Sören Brinkmann
2014-03-12 10:01 ` Michal Simek [this message]
2014-03-20 4:41 ` Appana Durga Kedareswara Rao
2014-03-10 15:15 ` Rob Herring
2014-03-10 15:22 ` Michal Simek
[not found] ` <531DD8C3.5050006@xilinx.com>
[not found] ` <531DD8C3.5050006-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2014-03-11 12:35 ` Appana Durga Kedareswara Rao
[not found] <1393939253-30245-1-git-send-email-appanad@xilinx.com>
2014-03-10 7:12 ` Appana Durga Kedareswara Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53203088.2070605@monstr.eu \
--to=monstr@monstr$(echo .)eu \
--cc=appana.durga.rao@xilinx$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=fengguang.wu@intel$(echo .)com \
--cc=grant.likely@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-can@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=michals@xilinx$(echo .)com \
--cc=mkl@pengutronix$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=robh+dt@kernel$(echo .)org \
--cc=wg@grandegger$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox