Subject: Re: [net-next 12/13] ixgbe: fix some multiline hw_dbg prints

From: Sergei Shtylyov <[email-masked]>
Date: Wed, 12 Mar 2014 23:24:03 +0300

On 03/12/2014 11:11 PM, Sergei Shtylyov wrote:

>>>> From: Jacob Keller <[email-masked]>

>>>> This patch fixes some formatting on multilined print messages, so that
>>>> the text of the print appears on a single line, which aids in grepping
>>>> the sourcecode for where the error came from.

>>>> Signed-off-by: Jacob Keller <[email-masked]>
>>>> Tested-by: Phil Schmitt <[email-masked]>
>>>> Signed-off-by: Jeff Kirsher <[email-masked]>
>>>> ---
>>>>    drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c | 8 +++-----
>>>>    1 file changed, 3 insertions(+), 5 deletions(-)

>>>> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c
>>>> b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c
>>>> index 446df3c..3bc9b67 100644
>>>> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c
>>>> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c
>>>> @@ -512,7 +512,7 @@ out:
>>>>     *
>>>>     * Disables link, should be called during D3 power down sequence.
>>>>     *
>>>> - */
>>>> + **/

>>>      Hm? What's this for?

>> The extra **/ is part of the standard doc format for function headers,

>     It is not. Reread Documentation/kernel-doc-nano-HOWTO.txt please.

    Sorry, I messed it myself -- it seems to be an optional part of the format 
which I've never seen actually used. Anyway, you shouldn't do "drove-by" 
changes like that, moreover undocumented in the change log.

WBR, Sergei