Subject: Re: [PATCH] micrel: fix masking off LED bits

From: Ben Dooks <[email-masked]>
Date: Wed, 19 Mar 2014 09:12:33 +0100

On 19/03/14 00:58, Sergei Shtylyov wrote:
> Commit 20d8435a1cff (phy: micrel: add of configuration for LED mode) made the
> obvious mistake when masking off  the LED mode bits: forgot to do a logical NOT
> to the mask with which it ANDs the register value, so that unrelated bits are
> cleared instead.
>
> Signed-off-by: Sergei Shtylyov <[email-masked]>
Acked-by: Ben Dooks <[email-masked]>

Oops, thanks for noticing that.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius