Subject: Re: [PATCH] micrel: fix masking off LED bits

From: Sergei Shtylyov <[email-masked]>
Date: Wed, 19 Mar 2014 22:35:30 +0300

Hello.

On 03/19/2014 07:21 PM, Florian Fainelli wrote:

>>> Commit 20d8435a1cff (phy: micrel: add of configuration for LED mode) made
>>> the
>>> obvious mistake when masking off  the LED mode bits: forgot to do a
>>> logical NOT
>>> to the mask with which it ANDs the register value, so that unrelated bits
>>> are
>>> cleared instead.

>>> Signed-off-by: Sergei Shtylyov <[email-masked]>

>> Acked-by: Ben Dooks <[email-masked]>

> Reviewed-by: Florian Fainelli <[email-masked]>

    Oh, sorry for not CCing you -- I forgot that phylib is now maintained.

WBR, Sergei