From: Ding Tianhong <dingtianhong@huawei•com>
To: Zheng Li <zheng.x.li@oracle•com>, <netdev@vger•kernel.org>,
<fubar@us•ibm.com>, <andy@greyhouse•net>
Cc: <linux-kernel@vger•kernel.org>, <davem@davemloft•net>,
<joe.jin@oracle•com>
Subject: Re: [PATCH] bonding: Inactive slaves should keep inactive flag's value to 1.
Date: Thu, 20 Mar 2014 17:36:12 +0800 [thread overview]
Message-ID: <532AB68C.1040003@huawei.com> (raw)
In-Reply-To: <1395305504-29973-1-git-send-email-zheng.x.li@oracle.com>
On 2014/3/20 16:51, Zheng Li wrote:
> Except bond mode 1, in other bond modes, inactive slaves should keep inactive flag to
> 1 to refuse to receive broadcast packets. Now, active slave send broadcast packets
> (for example ARP requests) which will arrive inactive slaves on same host from switch,
> but inactive slave's inactive flag is zero that cause bridge receive the broadcast
> packets to produce a wrong entry in forward table. Typical situation is domu send some
> ARP request which go out from dom0 bond's active slave, then the ARP broadcast request
> packets go back to inactive slave from switch, because the inactive slave's inactive
> flag is zero, kernel will receive the packets and pass them to bridge, that cause dom0's
> bridge map domu's MAC address to port of bond, bridge should map domu's MAC to port of vif.
>
> Signed-off-by: Zheng Li <zheng.x.li@oracle•com>
> ---
> drivers/net/bonding/bond_main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index e5628fc..2f73f18 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -3063,7 +3063,7 @@ static int bond_open(struct net_device *bond_dev)
> bond_set_slave_inactive_flags(slave,
> BOND_SLAVE_NOTIFY_NOW);
> } else {
> - bond_set_slave_active_flags(slave,
> + bond_set_slave_state(slave, BOND_STATE_ACTIVE,
> BOND_SLAVE_NOTIFY_NOW);
This patch could be applied?
Ding
> }
> }
>
next prev parent reply other threads:[~2014-03-20 9:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 8:51 [PATCH] bonding: Inactive slaves should keep inactive flag's value to 1 Zheng Li
2014-03-20 9:36 ` Ding Tianhong [this message]
2014-03-20 17:02 ` Jay Vosburgh
2014-03-21 2:39 ` zheng.li
2014-03-21 8:41 ` Ding Tianhong
2014-03-21 17:43 ` Jay Vosburgh
2014-03-24 9:01 ` zheng.li
2014-03-24 19:25 ` David Miller
2014-03-21 11:34 ` Sergei Shtylyov
-- strict thread matches above, loose matches on Subject: below --
2014-03-28 9:22 Zheng Li
2014-03-31 6:58 ` zheng.li
2014-04-01 0:35 ` Jay Vosburgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532AB68C.1040003@huawei.com \
--to=dingtianhong@huawei$(echo .)com \
--cc=andy@greyhouse$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=fubar@us$(echo .)ibm.com \
--cc=joe.jin@oracle$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=zheng.x.li@oracle$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox