From: Ding Tianhong <dingtianhong@huawei•com>
To: Michal Kubecek <mkubecek@suse•cz>
Cc: Jay Vosburgh <fubar@us•ibm.com>, <vfalico@redhat•com>,
<andy@greyhouse•net>, <kaber@trash•net>, <davem@davemloft•net>,
<netdev@vger•kernel.org>
Subject: Re: [PATCH net-next 2/2] bonding: support QinQ for bond arp interval
Date: Thu, 20 Mar 2014 18:21:25 +0800 [thread overview]
Message-ID: <532AC125.7030202@huawei.com> (raw)
In-Reply-To: <20140320094040.GB28839@unicorn.suse.cz>
On 2014/3/20 17:40, Michal Kubecek wrote:
> On Thu, Mar 20, 2014 at 05:29:39PM +0800, Ding Tianhong wrote:
>> On 2014/3/20 16:24, Michal Kubecek wrote:
>>> On Mon, Mar 17, 2014 at 10:46:04AM -0700, Jay Vosburgh wrote:
>>>> Ding Tianhong <dingtianhong@huawei•com> wrote:
>>>>>
>>>>> ip link add link bond0 bond0.20 type vlan proto 802.1ad id 20
>>>>> ip link add link bond0.20 bond0.20.200 type vlan proto 802.1q id 200
>>>>
>>>> Is this nesting backwards? The way I read it (and the way I
>>>> recall that VLANs nest), "bond0.20" is the "regular" VLAN, i.e., if we
>>>> just have bond0.20 it would be a standard 802.1q (ethertype 0x8100)
>>>> VLAN. Adding the second VLAN, .200 in this example, would be the second
>>>> (outer) tag, and would be the 802.1ad (ethertype 0x88a8) tag.
>>>>
>>>> In other words, adding a VLAN to an already existing VLAN makes
>>>> the newly added VLAN the "outer" and the already existing VLAN the
>>>> "inner." Am I confused?
>>>
>>> I don't think so. My understanding is that when sending a packet to
>>> a vlan device, it is tagged (according to its "proto") and passed to its
>>> underlying device.
>>>
>>> So in the case above, sending a packet to bond0.20.200 would add an
>>> 802.1q tag and pass the result to bond0.20 which would add an 802.1ad
>>> tag and pass the result to bond0. Which is the way it should work.
>>
>> I agree with your analysis of QinQ for vlan in common usage, but I think you miss
>> something for how the arp interval works, the bonding need to create a new
>> arp request with vlan tag to confirm that the slave should be active or unactive,
>> the skb could not be passed to bond0.20.200, we have to build QinQ skb ourselves.
>
> My comment referred only to the way stacked interfaces are set up in the
> quoted example, not to the original issue.
>
> Michal Kubecek
>
Sorry for that, I misunderstood.:)
Ding
>
> .
>
prev parent reply other threads:[~2014-03-20 10:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 12:06 [PATCH net-next 0/2] bonding: support QinQ for bond arp interval Ding Tianhong
2014-03-17 12:06 ` [PATCH net-next 1/2] vlan: make a new function vlan_dev_vlan_proto() and export Ding Tianhong
2014-03-17 12:06 ` [PATCH net-next 2/2] bonding: support QinQ for bond arp interval Ding Tianhong
2014-03-17 17:46 ` Jay Vosburgh
2014-03-18 1:59 ` Ding Tianhong
2014-03-20 8:24 ` Michal Kubecek
2014-03-20 9:29 ` Ding Tianhong
2014-03-20 9:40 ` Michal Kubecek
2014-03-20 10:21 ` Ding Tianhong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532AC125.7030202@huawei.com \
--to=dingtianhong@huawei$(echo .)com \
--cc=andy@greyhouse$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=fubar@us$(echo .)ibm.com \
--cc=kaber@trash$(echo .)net \
--cc=mkubecek@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vfalico@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox