From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard•com>,
netdev@vger•kernel.org
Cc: linux-sh@vger•kernel.org, Ben Dooks <ben.dooks@codethink•co.uk>
Subject: Re: [PATCH 3/5] sh_eth: Simplify MDIO bus initialization and release
Date: Thu, 20 Mar 2014 19:31:13 +0400 [thread overview]
Message-ID: <532B09C1.5030201@cogentembedded.com> (raw)
In-Reply-To: <1395324035-22918-4-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On 20-03-2014 18:00, Laurent Pinchart wrote:
> The network device passed to the sh_mdio_init and sh_mdio_release
> functions is only used to access the sh_eth_private instance. Pass it
> directly to those functions.
The changelog is incomplete now. You added significant changes but forgot
to document them.
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard•com>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k•org>
> ---
> drivers/net/ethernet/renesas/sh_eth.c | 30 +++++++++++-------------------
> 1 file changed, 11 insertions(+), 19 deletions(-)
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index 443f14f..e9224f2 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -2583,29 +2583,24 @@ static void sh_eth_tsu_init(struct sh_eth_private *mdp)
[...]
> -static int sh_mdio_init(struct net_device *ndev, int id,
> +static int sh_mdio_init(struct sh_eth_private *mdp,
> struct sh_eth_plat_data *pd)
> {
> int ret, i;
> struct bb_info *bitbang;
> - struct sh_eth_private *mdp = netdev_priv(ndev);
> + struct platform_device *pdev = mdp->pdev;
> struct device *dev = &mdp->pdev->dev;
struct device *dev = &pdev->dev;
> @@ -2635,7 +2630,7 @@ static int sh_mdio_init(struct net_device *ndev, int id,
> mdp->mii_bus->name = "sh_mii";
> mdp->mii_bus->parent = dev;
> snprintf(mdp->mii_bus->id, MII_BUS_ID_SIZE, "%s-%x",
> - mdp->pdev->name, id);
> + pdev->name, pdev->id);
>
> /* PHY IRQ */
> mdp->mii_bus->irq = devm_kzalloc(dev, sizeof(int) * PHY_MAX_ADDR,
WBR, Sergei
next prev parent reply other threads:[~2014-03-20 15:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 14:00 [PATCH 0/5] sh_eth: Fix the race between open and MDIO bus registration Laurent Pinchart
2014-03-20 14:00 ` [PATCH 1/5] sh_eth: Use the platform device for memory allocation Laurent Pinchart
2014-03-20 14:00 ` [PATCH 2/5] sh_eth: Use the platform device as the MDIO bus parent Laurent Pinchart
2014-03-20 14:00 ` [PATCH 3/5] sh_eth: Simplify MDIO bus initialization and release Laurent Pinchart
2014-03-20 15:31 ` Sergei Shtylyov [this message]
2014-03-20 14:00 ` [PATCH 4/5] sh_eth: Register MDIO bus before registering the network device Laurent Pinchart
2014-03-20 14:00 ` [PATCH 5/5] sh_eth: Remove goto statements that jump straight to a return Laurent Pinchart
2014-03-20 21:22 ` [PATCH 0/5] sh_eth: Fix the race between open and MDIO bus registration David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532B09C1.5030201@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=ben.dooks@codethink$(echo .)co.uk \
--cc=laurent.pinchart+renesas@ideasonboard$(echo .)com \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox