From: Nicolas Dichtel <nicolas.dichtel@6wind•com>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, tgraf@suug•ch
Subject: Re: [PATCH net 1/3] rtnetlink: fix fdb notification flags
Date: Fri, 21 Mar 2014 10:18:36 +0100 [thread overview]
Message-ID: <532C03EC.1060902@6wind.com> (raw)
In-Reply-To: <20140320.162503.536482270990113339.davem@davemloft.net>
Le 20/03/2014 21:25, David Miller a écrit :
> From: Nicolas Dichtel <nicolas.dichtel@6wind•com>
> Date: Wed, 19 Mar 2014 17:47:49 +0100
>
>> Commit 3ff661c38c84 ("net: rtnetlink notify events for FDB NTF_SELF adds and
>> deletes") reuses the function nlmsg_populate_fdb_fill() to notify fdb events.
>> But this function was used only for dump and thus was always setting the
>> flag NLM_F_MULTI, which is wrong in case of a single notification.
>>
>> Libraries like libnl will wait forever for NLMSG_DONE.
>>
>> CC: Thomas Graf <tgraf@suug•ch>
>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind•com>
>
> Applied.
>
David, do you plan to queue this serie in stable branch?
Applications using libnl may be stuck with this bug.
Thank you,
Nicolas
next prev parent reply other threads:[~2014-03-21 9:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 16:47 [PATCH net 1/3] rtnetlink: fix fdb notification flags Nicolas Dichtel
2014-03-19 16:47 ` [PATCH net 2/3] ipmr: fix mfc " Nicolas Dichtel
2014-03-20 7:39 ` Thomas Graf
2014-03-20 20:25 ` David Miller
2014-03-19 16:47 ` [PATCH net 3/3] ip6mr: " Nicolas Dichtel
2014-03-20 7:39 ` Thomas Graf
2014-03-20 20:25 ` David Miller
2014-03-20 7:38 ` [PATCH net 1/3] rtnetlink: fix fdb " Thomas Graf
2014-03-20 20:25 ` David Miller
2014-03-21 9:18 ` Nicolas Dichtel [this message]
2014-03-21 18:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532C03EC.1060902@6wind.com \
--to=nicolas.dichtel@6wind$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tgraf@suug$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox