From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Fabio Estevam <fabio.estevam@freescale•com>,
steve.glendinning@shawell•net
Cc: netdev@vger•kernel.org, davem@davemloft•net
Subject: Re: [PATCH] smsc911x: Change clock warning message to debug level
Date: Fri, 21 Mar 2014 15:09:36 +0300 [thread overview]
Message-ID: <532C2C00.4080901@cogentembedded.com> (raw)
In-Reply-To: <1395238926-16126-1-git-send-email-fabio.estevam@freescale.com>
Hello.
On 03/19/2014 05:22 PM, Fabio Estevam wrote:
> Since passing the clock is not mandatory, change the warning message to debug,
> so that we avoid getting the following clock failure message on every boot:
> smsc911x: Driver version 2008-10-21
> smsc911x smsc911x (unregistered net_device): couldn't get clock -2
> libphy: smsc911x-mdio: probed
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale•com>
> ---
> drivers/net/ethernet/smsc/smsc911x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
> index 6382b7c..95e2b9a 100644
> --- a/drivers/net/ethernet/smsc/smsc911x.c
> +++ b/drivers/net/ethernet/smsc/smsc911x.c
> @@ -439,7 +439,7 @@ static int smsc911x_request_resources(struct platform_device *pdev)
> /* Request clock */
> pdata->clk = clk_get(&pdev->dev, NULL);
> if (IS_ERR(pdata->clk))
> - netdev_warn(ndev, "couldn't get clock %li\n", PTR_ERR(pdata->clk));
> + netdev_dbg(ndev, "couldn't get clock %li\n", PTR_ERR(pdata->clk));
Looks like using netdev_dbg() is premature at this point (see that
"unregistered net_device"), so I'd replace netdev_*(ndev, ...) with
dev_*(&pdev->dev, ...)
WBR, Sergei
prev parent reply other threads:[~2014-03-21 11:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 14:22 [PATCH] smsc911x: Change clock warning message to debug level Fabio Estevam
2014-03-20 20:17 ` David Miller
2014-03-21 12:09 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532C2C00.4080901@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=fabio.estevam@freescale$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=steve.glendinning@shawell$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox