Subject: Re: [PATCH net-next resend] net/mlx4_core: pass pci_device_id.driver_data to __mlx4_init_one during reset

From: Sergei Shtylyov <[email-masked]>
Date: Wed, 26 Mar 2014 18:02:27 +0400

Hello.

On 26-03-2014 14:15, Wei Yang wrote:

> [Note: seems my network/mail system got some problem yesterday. Resend it in
> case it is lost. If you have already got one, please ignore it.]

    Put such remarks under --- tear line in the future, so that David don't 
have to edit them out when applying.

> The second parameter of __mlx4_init_one() is used to identify whether the
> pci_dev is a PF or VF. Currently, when it is invoked in mlx4_pci_slot_reset()
> this information is missed.

> This patch match the pci_dev with mlx4_pci_table and passes the
> pci_device_id.driver_data to __mlx4_init_one() in mlx4_pci_slot_reset().

> Signed-off-by: Wei Yang <[email-masked]>
> ---
>   drivers/net/ethernet/mellanox/mlx4/main.c |    6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)

> diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
> index d711158..b083808 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/main.c
> @@ -2670,7 +2670,11 @@ static pci_ers_result_t mlx4_pci_err_detected(struct pci_dev *pdev,
>
>   static pci_ers_result_t mlx4_pci_slot_reset(struct pci_dev *pdev)
>   {
> -	int ret = __mlx4_init_one(pdev, 0);
> +	const struct pci_device_id*  id;

    * should be close to 'id' and one space is enough. I guess you haven't run 
your patch thru scripts/checkpatch.pl?

WBR, Sergei