Subject: Re: [PATCH v2 net 1/2] net: Allow modules to use is_skb_forwardable

From: Sergei Shtylyov <[email-masked]>
Date: Wed, 26 Mar 2014 22:18:33 +0300

Hello.

On 03/26/2014 07:14 PM, Vlad Yasevich wrote:

> Signed-off-by: Vlad Yasevich <[email-masked]>
[...]

> diff --git a/net/core/dev.c b/net/core/dev.c
> index b1b0c8d..a98f7fa 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -1645,7 +1645,7 @@ static inline void net_timestamp_set(struct sk_buff *skb)
>   			__net_timestamp(SKB);		\
>   	}						\
>
> -static inline bool is_skb_forwardable(struct net_device *dev,
> +bool is_skb_forwardable(struct net_device *dev,
>   				      struct sk_buff *skb)

    Please re-indent the above line, so that it still starts under *struct*.

>   {
>   	unsigned int len;

WBR, Sergei