From: Dinh Nguyen <dinh.linux@gmail•com>
To: Gerhard Sittig <gsi@denx•de>, dinguyen@altera•com
Cc: arnd@arndb•de, davem@davemloft•net, peppe.cavallaro@st•com,
mark.rutland@arm•com, devicetree@vger•kernel.org,
pawel.moll@arm•com, srinivas.kandagatla@st•com,
netdev@vger•kernel.org, ijc+devicetree@hellion•org.uk,
robh+dt@kernel•org, arm@kernel•org, galak@codeaurora•org,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH 2/3] dts: socfpga: Fix ethernet entries for the stmmac
Date: Wed, 26 Mar 2014 19:05:41 -0500 [thread overview]
Message-ID: <53336B55.7080605@gmail.com> (raw)
In-Reply-To: <20140326221225.GP3998@book.gsilab.sittig.org>
On 03/26/2014 05:12 PM, Gerhard Sittig wrote:
> On Tue, 2014-03-25 at 18:34 -0500, dinguyen@altera•com wrote:
>>
>> - #size-cells = <1>;
>> - compatible = "altr,socfpga-stmmac";
>> - altr,sysmgr-syscon = <&sysmgr 0x60>;
>> + gmac0: ethernet@ff700000 {
>> + compatible = "altr,socfpga-stmmac", "snps,dwmac-3.70a", "snps,dwmac";
>> status = "disabled";
>> - ranges;
>> -
>> - gmac0: gmac0@ff700000 {
>> - compatible = "snps,dwmac-3.70a", "snps,dwmac";
>> - reg = <0xff700000 0x2000>;
>> - interrupts = <0 115 4>;
>> - interrupt-names = "macirq";
>> - mac-address = [00 00 00 00 00 00];/* Filled in by U-Boot */
>> - clocks = <&emac0_clk>;
>> - clock-names = "stmmaceth";
>> - };
>> + altr,sysmgr-syscon = <&sysmgr 0x60>;
>> + reg = <0xff700000 0x2000>;
>> + interrupts = <0 115 4>;
>> + interrupt-names = "macirq";
>> + mac-address = [00 00 00 00 00 00];/* Filled in by U-Boot */
>> + clocks = <&emac0_clk>;
>> + clock-names = "stmmaceth";
>> };
>
> not strictly related to this patch, but noticed in bypassing:
>
> is the 'clocks' spec correct? ISTR that 'emac0_clk' is the PLL
> output, while the gated clock for the EMAC IP block is named
> 'emac_0_clk' (note the extra underscore)
>
Yes, you're right. Thanks for catching that.
Dinh
>
> virtually yours
> Gerhard Sittig
>
next prev parent reply other threads:[~2014-03-27 0:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 23:34 [PATCH 0/3] Fix stmmac-socfpga allmodconfig breakage in arm-soc dinguyen-EIB2kfCEclfQT0dZR+AlfA
[not found] ` <1395790482-3957-1-git-send-email-dinguyen-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org>
2014-03-25 23:34 ` [PATCH 1/3] net: stmmac: improve binding and fix build dinguyen-EIB2kfCEclfQT0dZR+AlfA
2014-03-25 23:34 ` [PATCH 2/3] dts: socfpga: Fix ethernet entries for the stmmac dinguyen
2014-03-26 22:12 ` Gerhard Sittig
2014-03-27 0:05 ` Dinh Nguyen [this message]
2014-03-25 23:34 ` [PATCH 3/3] dts: documentation: Update documentation for the stmmac ethernet controller dinguyen
2014-03-26 21:54 ` [PATCH 0/3] Fix stmmac-socfpga allmodconfig breakage in arm-soc Arnd Bergmann
2014-03-27 0:05 ` Dinh Nguyen
[not found] ` <53336B39.3080209-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-03-27 0:29 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53336B55.7080605@gmail.com \
--to=dinh.linux@gmail$(echo .)com \
--cc=arm@kernel$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dinguyen@altera$(echo .)com \
--cc=galak@codeaurora$(echo .)org \
--cc=gsi@denx$(echo .)de \
--cc=ijc+devicetree@hellion$(echo .)org.uk \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pawel.moll@arm$(echo .)com \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=srinivas.kandagatla@st$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox