Subject: Re: [PATCH v2] bridge: Fix crash with vlan filtering and tcpdump

From: Toshiaki Makita <[email-masked]>
Date: Fri, 28 Mar 2014 12:33:11 +0900

(2014/03/28 10:51), Vlad Yasevich wrote:
> When the vlan filtering is enabled on the bridge, but
> the filter is not configured on the bridge device itself,
> running tcpdump on the bridge device will result in a
> an Oops with NULL pointer dereference.  The reason
> is that br_pass_frame_up() will bypass the vlan
> check because promisc flag is set.  It will then try
> to get the table pointer and process the packet based
> on the table.  Since the table pointer is NULL, we oops.
> Catch this special condition in br_handle_vlan().
> 
> Reported-by: Toshiaki Makita <[email-masked]>
> CC: Toshiaki Makita <[email-masked]>
> Signed-off-by: Vlad Yasevich <[email-masked]>

Thanks,

Acked-by: Toshiaki Makita <[email-masked]>