From: wangyufen <wangyufen@huawei•com>
To: Joe Perches <joe@perches•com>
Cc: David Miller <davem@davemloft•net>, <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next v2 3/3] ipv6: fix checkpatch errors of "foo*" and "foo * bar"
Date: Fri, 28 Mar 2014 17:33:54 +0800 [thread overview]
Message-ID: <53354202.4080108@huawei.com> (raw)
In-Reply-To: <1395985645.31134.2.camel@joe-AO722>
On 2014/3/28 13:47, Joe Perches wrote:
> On Fri, 2014-03-28 at 01:40 -0400, David Miller wrote:
>> From: Joe Perches <joe@perches•com>
>> Date: Thu, 27 Mar 2014 21:22:01 -0700
>>
>>> On Fri, 2014-03-28 at 12:07 +0800, Wangyufen wrote:
>>> []
>>>> diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c
>>> []
>>>> @@ -143,7 +143,7 @@ static __inline__ __be32 addr_bit_set(const void *token, int fn_bit)
>>>> addr[fn_bit >> 5];
>>>> }
>>>
>>> Perhaps all the __inline__ uses could be changed to inline too.
>>
>> Or rather, deleted completely, this is a *.c file after all.
>
> Maybe right. There are a lot though just in net/
>
> $ git ls-files net | grep "\.c$" | \
> xargs grep -Pw "_{0,2}inline_{0,2}" | wc -l
> 1512
>
>
>
>
>
Or change to inline and move the whole function to ip6_fib.h?
next prev parent reply other threads:[~2014-03-28 9:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 4:07 [PATCH net-next v2 0/3] ipv6: fix checkpatch errors and warnings Wangyufen
2014-03-28 4:07 ` [PATCH net-next v2 1/3] ipv6: fix checkpatch errors comments and space Wangyufen
2014-03-28 4:07 ` [PATCH net-next v2 2/3] ipv6: fix checkpatch errors of brace and trailing statements Wangyufen
2014-03-28 4:07 ` [PATCH net-next v2 3/3] ipv6: fix checkpatch errors of "foo*" and "foo * bar" Wangyufen
2014-03-28 4:22 ` Joe Perches
2014-03-28 5:40 ` David Miller
2014-03-28 5:47 ` Joe Perches
2014-03-28 9:33 ` wangyufen [this message]
2014-03-28 17:09 ` David Miller
2014-03-28 10:17 ` Hannes Frederic Sowa
2014-03-28 10:54 ` David Laight
2014-03-28 18:16 ` Hannes Frederic Sowa
2014-03-28 13:30 ` Sergei Shtylyov
2014-03-29 22:16 ` [PATCH net-next v2 0/3] ipv6: fix checkpatch errors and warnings David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53354202.4080108@huawei.com \
--to=wangyufen@huawei$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=joe@perches$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox