From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6•org>
To: Tom Herbert <therbert@google•com>
Cc: Linux Netdev List <netdev@vger•kernel.org>,
David Miller <davem@davemloft•net>,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6•org>
Subject: Re: [PATCH net-next 6/6] net: Implmement RFC 6936 (zero RX csums for UDP/IPv6)
Date: Tue, 08 Apr 2014 10:17:03 +0900 [thread overview]
Message-ID: <53434E0F.90707@linux-ipv6.org> (raw)
In-Reply-To: <CA+mtBx_gUsovA87Fqpn+zzDzNL7wJ7YWX3_pfcZORg=nexXHcw@mail.gmail.com>
Tom Herbert wrote:
>>> while (sk) {
>>> + if (!uh->check && !udp_sk(sk)->check6_zero_okay) {
>>> + /*
>>> + * If checksum in packet is zero and not all the
>>> + * sockets accept a zero checksum then declare
>>> + * a checksum error.
>>> + */
>>> + flush_stack(stack, count, skb, ~0);
>>> + count = 0;
>>> + udp6_csum_zero_error(skb);
>>> + UDP6_INC_STATS_BH(net, UDP_MIB_CSUMERRORS, proto == IPPROTO_UDPLITE);
>>> + UDP6_INC_STATS_BH(net, UDP_MIB_INERRORS, proto == IPPROTO_UDPLITE);
>>> + break;
>>> + }
>>> stack[count++] = sk;
>>> sk = udp_v6_mcast_next(net, sk_nulls_next(sk), uh->dest, daddr,
>>> uh->source, saddr, dif);
>>
>> This seems wrong; packets with zero-checksum will not be delivered to
>> some sockets if some of sockets accept zero-checksums and others do not.
>>
> Okay, I suppose delivering to some and not others is reasonable,
> although there's no accounting for the non-deliverables-- I suppose
> there's no completely clean way to do this...
Well, I believe that supporting UDP packets with zero-checksum
should be implemented in a consistent way with UDP-lite.
>> BTW, I have been thinking that we should introduce 4 options
>> (or bits) for IPv4/IPv6 checksumming for sender/receiver.
>>
> What are these 4 options?
I meant combination of {ipv4,ipv6} and {sender,receiver}.
--yoshfuji
next prev parent reply other threads:[~2014-04-08 1:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-05 0:28 [PATCH net-next 6/6] net: Implmement RFC 6936 (zero RX csums for UDP/IPv6) Tom Herbert
2014-04-05 21:56 ` Tom Herbert
2014-04-07 17:16 ` David Miller
2014-04-07 17:25 ` Eric Dumazet
2014-04-07 20:44 ` Tom Herbert
2014-04-07 18:48 ` YOSHIFUJI Hideaki
2014-04-07 20:53 ` Tom Herbert
2014-04-08 1:17 ` YOSHIFUJI Hideaki [this message]
2014-04-08 15:47 ` Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53434E0F.90707@linux-ipv6.org \
--to=yoshfuji@linux-ipv6$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=therbert@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox