From: Or Gerlitz <ogerlitz@mellanox•com>
To: David Miller <davem@davemloft•net>, <weiyang@linux•vnet.ibm.com>
Cc: <yevgenyp@mellanox•com>, <amirv@mellanox•com>,
<bhelgaas@google•com>, <linux-pci@vger•kernel.org>,
<netdev@vger•kernel.org>
Subject: Re: [Patch net-next] net/mlx4_core: match pci_device_id including dynids
Date: Tue, 8 Apr 2014 09:48:30 +0300 [thread overview]
Message-ID: <53439BBE.4070708@mellanox.com> (raw)
In-Reply-To: <20140407.144340.688537373203786487.davem@davemloft.net>
On 07/04/2014 21:43, David Miller wrote:
> From: Wei Yang <weiyang@linux•vnet.ibm.com>
> Date: Sun, 6 Apr 2014 10:07:30 +0800
>
>> Fix issue introduced by commit: 97a5221 "net/mlx4_core: pass
>> pci_device_id.driver_data to __mlx4_init_one during reset".
>>
>> pci_match_id() just match the static pci_device_id, which may return NULL if
>> someone binds the driver to a device manually using
>> /sys/bus/pci/drivers/.../new_id.
>>
>> This patch wrap up a helper function __mlx4_remove_one() which does the tear
>> down function but preserve the drv_data. Functions like
>> mlx4_pci_err_detected() and mlx4_restart_one() will call this one with out
>> releasing drvdata.
>>
>> Tested on ConnectX-3.
>>
>> CC: Bjorn Helgaas <bhelgaas@google•com>
>> CC: Amir Vadai <amirv@mellanox•com>
>> Signed-off-by: Wei Yang <weiyang@linux•vnet.ibm.com>
> Please resubmit this when the net-next tree opens back up, thanks.
Dave, this patch is for net, since it fixes an issue in the current code
(actually it relates to a patch
that was merged after 3.14-rc7, so it would eventually might go to
-stable too). The author wasn't very
familiar with the exact differences/nature of net vs. net-next, so it
might created some confusion here, I'v
sent him few private notes to explain how things go...
Or.
next prev parent reply other threads:[~2014-04-08 6:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-06 2:07 [Patch net-next] net/mlx4_core: match pci_device_id including dynids Wei Yang
2014-04-07 18:43 ` David Miller
2014-04-08 6:48 ` Or Gerlitz [this message]
2014-04-08 7:45 ` Wei Yang
2014-04-08 16:25 ` David Miller
2014-04-08 16:51 ` Or Gerlitz
2014-04-08 6:52 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53439BBE.4070708@mellanox.com \
--to=ogerlitz@mellanox$(echo .)com \
--cc=amirv@mellanox$(echo .)com \
--cc=bhelgaas@google$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=weiyang@linux$(echo .)vnet.ibm.com \
--cc=yevgenyp@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox