Subject: Re: [PATCH] net: sun4i-emac: add promiscuous support

From: Stefan Roese <[email-masked]>
Date: Fri, 11 Apr 2014 11:55:50 +0200

On 11.04.2014 11:46, Marc Zyngier wrote:
> The sun4i-emac driver is rather primitive, and doesn't support
> promiscuous mode. This makes usage such as bridging impossible,
> which is a shame on virtualization capable HW such as the
> Allwinner A20.
>
> The fix is fairly simple: move the RX setup code to the ndo_set_rx_mode
> vector, and add the required HW configuration when IFF_PROMISC is passed
> by the core code.
>
> This has been tested on a generic A20 box running a few virtual
> machines hanging off a bridge with the EMAC chip as the link to the
> outside world.
>
> Cc: Stefan Roese <[email-masked]>
> Cc: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/[email-masked]>
> Signed-off-by: Marc Zyngier <[email-masked]>

Looks good, so:

Acked-by: Stefan Roese <[email-masked]>

Thanks,
Stefan