Subject: Re: [PATCH] net IPv6: Remove unnecessary argument of ndisc_send_ns and ndisc_send_na

From: YOSHIFUJI Hideaki <[email-masked]>
Date: Mon, 14 Apr 2014 14:13:18 +0900

Balakumaran Kannan wrote:
> The 'neigh' argument of 'ndisc_send_ns' and 'ndisc_send_na' are not used in
> these functions. So this could be removed.
> 
> And a minor change of 'optlen' assignment in those functions. the compound
> addition and assignment operator is not needed as 'optlen' value is always
> zero.

Do not mix changes.

Well, it is for future extension so that we can prepend another option
easier.  Do you see any penalty here?

> 
> Signed-off-by: Balakumaran Kannan <[email-masked]>
> ---
> I am not sure whether 'neigh' argument is intentional or planned for any
> future use. If you find this is unnecessary, this patch could be considered.
> 
> And ndisc_send_na is used as a function pointer in ipv6_stub. This may affect anybody
> using this structure. But with default configuration built, I didn't get any error or
> warning. Kindly consider this scenario also. 

drivers/net/usb/cdc_mbim.c uses it at least.

--yoshfuji