From: Edward Cree <ecree@solarflare•com>
To: Shradha Shah <sshah@solarflare•com>
Cc: David Miller <davem@davemloft•net>, <netdev@vger•kernel.org>,
<linux-net-drivers@solarflare•com>,
Robert Stonehouse <rstonehouse@solarflare•com>
Subject: Re: [PATCH net] sfc:On MCDI timeout, issue an FLR (and mark MCDI to fail-fast)
Date: Mon, 14 Apr 2014 16:02:54 +0100 [thread overview]
Message-ID: <534BF89E.5020603@solarflare.com> (raw)
In-Reply-To: <534BF37F.6020604@solarflare.com>
On 14/04/14 15:41, Shradha Shah wrote:
> diff --git a/drivers/net/ethernet/sfc/enum.h b/drivers/net/ethernet/sfc/enum.h
> index 75ef7ef..70c2473 100644
> --- a/drivers/net/ethernet/sfc/enum.h
> +++ b/drivers/net/ethernet/sfc/enum.h
> @@ -165,7 +168,14 @@ enum reset_type {
> RESET_TYPE_DMA_ERROR,
> RESET_TYPE_TX_SKIP,
> RESET_TYPE_MC_FAILURE,
> - RESET_TYPE_MC_BIST,
> + /* RESET_TYPE_MC_BIST and RESET_TYPE_MCDI_TIMEOUT are actually methods,
> + * not just reasons, but they don't fit the scope hierarchy (they're
> + * not well-ordered by inclusion)
> + * We encode this by having their enum values be greater than
> + * RESET_TYPE_MAX_METHOD. This also prevents issuing them with
> + * efx_ioctl_reset
> + */
> + RESET_TYPE_MCDI_TIMEOUT,
> RESET_TYPE_MAX,
> };
>
Looks like I messed up this comment; this is only true of
RESET_TYPE_MCDI_TIMEOUT, not RESET_TYPE_MC_BIST.
So should be something like:
/* RESET_TYPE_MCDI_TIMEOUT is actually a method, not just a reason, but
* it doesn't fit the scope hierarchy (not well-ordered by inclusion).
* We encode this by having its enum value be greater than
* RESET_TYPE_MAX_METHOD. This also prevents issuing it with
* efx_ioctl_reset.
*/
-Edward
next prev parent reply other threads:[~2014-04-14 15:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 14:41 [PATCH net] sfc:On MCDI timeout, issue an FLR (and mark MCDI to fail-fast) Shradha Shah
2014-04-14 15:02 ` Edward Cree [this message]
2014-04-14 17:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534BF89E.5020603@solarflare.com \
--to=ecree@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-net-drivers@solarflare$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rstonehouse@solarflare$(echo .)com \
--cc=sshah@solarflare$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox