From: Amir Vadai <amirv@mellanox•com>
To: Chris Mason <clm@fb•com>, <netdev@vger•kernel.org>
Subject: Re: [PATCH] mlx4_en: don't use napi_synchronize inside mlx4_en_netpoll
Date: Wed, 16 Apr 2014 17:20:44 +0300 [thread overview]
Message-ID: <534E91BC.1030908@mellanox.com> (raw)
In-Reply-To: <534DAE14.2090604@fb.com>
On 4/16/2014 1:09 AM, Chris Mason wrote:
>
>
> The mlx4 driver is triggering schedules while atomic inside
> mlx4_en_netpoll:
>
> spin_lock_irqsave(&cq->lock, flags);
> napi_synchronize(&cq->napi);
> ^^^^^ msleep here
> mlx4_en_process_rx_cq(dev, cq, 0);
> spin_unlock_irqrestore(&cq->lock, flags);
>
> This was part of a patch by Alexander Guller from Mellanox in 2011,
> but it still isn't upstream.
>
> Signed-off-by: Chris Mason <clm@fb•com>
> cc: stable@vger•kernel.org
> ---
> drivers/net/ethernet/mellanox/mlx4/en_cq.c | 1 -
> drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 6 +-----
> drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 1 -
> 3 files changed, 1 insertion(+), 7 deletions(-)
>
Acked-By: Amir Vadai <amirv@mellanox•com>
prev parent reply other threads:[~2014-04-16 14:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 22:09 [PATCH] mlx4_en: don't use napi_synchronize inside mlx4_en_netpoll Chris Mason
2014-04-16 14:20 ` Amir Vadai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534E91BC.1030908@mellanox.com \
--to=amirv@mellanox$(echo .)com \
--cc=clm@fb$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox